From: Chris Mason <chris.mason@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Shaohua Li <shaohua.li@intel.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Arjan van de Ven <arjan@linux.intel.com>,
"Wu, Fengguang" <fengguang.wu@intel.com>
Subject: Re: [patch 0/2]btrfs: add two ioctls to do metadata readahead
Date: Mon, 19 Jul 2010 07:25:56 -0400 [thread overview]
Message-ID: <20100719112556.GW8623@think> (raw)
In-Reply-To: <20100719080354.GA12808@infradead.org>
On Mon, Jul 19, 2010 at 04:03:54AM -0400, Christoph Hellwig wrote:
> This seems like iteration 66 of the ill fated mobling readahead crap.
>
> Please go to linux-fsdevel to define a proper interface instead of
> your per-filesystem hacks. I had hoped Arjan got it after the last big
> flameware, but it seems like you're only moving from one target to the
> next.
>
> NACK in this current form.
Honestly I think its good to have some of these features in specific
filesystems at first. Sure, it is easy to tell if they help in the lab
and during development, but why go through the pain of implementing them
in generic form until they have been through a broader test?
So the idea for the feature is fine with me, especially for something
like readahead which we can support forever by turning it into a noop if
there turns out to be a better idea.
-chris
next prev parent reply other threads:[~2010-07-19 11:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 8:02 [patch 0/2]btrfs: add two ioctls to do metadata readahead Shaohua Li
2010-07-14 8:26 ` Shaohua Li
2010-07-19 5:43 ` Shaohua Li
2010-07-19 8:03 ` Christoph Hellwig
2010-07-19 11:25 ` Chris Mason [this message]
2010-07-19 14:00 ` Arjan van de Ven
2010-07-20 3:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100719112556.GW8623@think \
--to=chris.mason@oracle.com \
--cc=arjan@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).