From: Christoph Hellwig <hch@infradead.org>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Shaohua Li <shaohua.li@intel.com>,
Chris Mason <chris.mason@oracle.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"Wu, Fengguang" <fengguang.wu@intel.com>
Subject: Re: [patch 0/2]btrfs: add two ioctls to do metadata readahead
Date: Mon, 19 Jul 2010 23:58:05 -0400 [thread overview]
Message-ID: <20100720035805.GA18049@infradead.org> (raw)
In-Reply-To: <4C445A81.5010808@linux.intel.com>
On Mon, Jul 19, 2010 at 07:00:33AM -0700, Arjan van de Ven wrote:
> On 7/19/2010 1:03 AM, Christoph Hellwig wrote:
> >This seems like iteration 66 of the ill fated mobling readahead crap.
>
> I think you need to actually look at what this patch does before
> rendering this judgment; something you apparently have not done.
Thanks a lot for the attack, but of course I have. It's the same stupid
idea of throwing almost generic code into filesystems that you previous
attempt did. It's completely generic code for checking what pages are
in-memory (plus constaints) and then force read-ahead on them again.
The only filesystems specific bit is which address_space to select. The
whole apporach is also useful to extN / xfs / etc if you allow it on
any address_space.
prev parent reply other threads:[~2010-07-20 3:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 8:02 [patch 0/2]btrfs: add two ioctls to do metadata readahead Shaohua Li
2010-07-14 8:26 ` Shaohua Li
2010-07-19 5:43 ` Shaohua Li
2010-07-19 8:03 ` Christoph Hellwig
2010-07-19 11:25 ` Chris Mason
2010-07-19 14:00 ` Arjan van de Ven
2010-07-20 3:58 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100720035805.GA18049@infradead.org \
--to=hch@infradead.org \
--cc=arjan@linux.intel.com \
--cc=chris.mason@oracle.com \
--cc=fengguang.wu@intel.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).