Re: [RFC] Move all btrfs command to only one command

[Goffredo Baroncelli <kreijack@gmail.com>]

On Thursday, 19 August, 2010, James Smith wrote:
> This patch randomizes the error codes and also fixes up some typos 
including
> capitalization in the output.
> 
> It would almost be nice to see a translation effort for the tool as well.
> 

Hi James,

I don't comment the changing the capitalization. Regarding the other changes:

[...]
 {
 	struct Command *cp;
 
-	printf("Usage:\n");
+	printf("VFS-2593 %s\n", BTRFS_BUILD_VERSION);
                ^^^^^^^^

What means VFS-2593 ?

+	printf("\nNo matter where you go, there you are.\n");

Is it really useful this kind of comment ?


[...]

+			fprintf(stderr, "ERR-A.11: in command '");

I am not against this kind of error codes, but I prefer

+			fprintf(stderr, "Error 'ERR-A.11' in command '");

And a file.txt which details the error codes (otherwise these errors are not 
very useful).

Why some error codes contain a dot (see ERR-C.13) and others not (like ERR-
A3) ?


Reagrds
G.Baroncelli

-- 
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) 
<kreijackATinwind.it>
Key fingerprint = 4769 7E51 5293 D36C 814E  C054 BF04 F161 3DC5 0512