From: Goffredo Baroncelli <kreijack@gmail.com>
To: Josef Bacik <josef@redhat.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs-progs: add btrfs filesystem disk-info command
Date: Wed, 29 Sep 2010 07:33:43 +0200 [thread overview]
Message-ID: <201009290733.44028.kreijack@libero.it> (raw)
In-Reply-To: <20100929003047.GE32420@dhcp231-156.rdu.redhat.com>
On Wednesday, 29 September, 2010, Josef Bacik wrote:
> On Wed, Sep 29, 2010 at 12:48:15AM +0200, Goffredo Baroncelli wrote:
> > Hi Josef,
> >
> > please, if you add or change a command pay attention to update the man
page
> > too (man/btrfs.8.in).
> >
>
> Hrm I missed that with git add, I'll fix that up.
[...]
> > > +
> > > + ret = ioctl(fd, BTRFS_IOC_DISK_INFO, args);
> > > + if (ret) {
> > > + printf("failed ioctl\n");
> > Please use
> > fprintf(stderr,"ERROR: failed ioctl\n");
> >
>
> Ugh oops sorry, forgot to get rid of my debug printing, I'll kill that.
If you use this command on a non btrfs filesystem, this is the first point of
failure. So please don't kill it.
--
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijack@inwind.it>
Key fingerprint = 4769 7E51 5293 D36C 814E C054 BF04 F161 3DC5 0512
prev parent reply other threads:[~2010-09-29 5:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 20:53 [PATCH] Btrfs-progs: add btrfs filesystem disk-info command Josef Bacik
2010-09-28 22:48 ` Goffredo Baroncelli
2010-09-29 0:30 ` Josef Bacik
2010-09-29 5:33 ` Goffredo Baroncelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009290733.44028.kreijack@libero.it \
--to=kreijack@gmail.com \
--cc=josef@redhat.com \
--cc=kreijack@libero.it \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox