From: Christoph Hellwig <hch@infradead.org>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Ric Wheeler <rwheeler@redhat.com>,
Lennart Poettering <lennart@poettering.net>,
Josef Bacik <josef@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: add a disk info ioctl to get the disks attached to a filesystem
Date: Wed, 29 Sep 2010 19:43:27 -0400 [thread overview]
Message-ID: <20100929234327.GA8401@infradead.org> (raw)
In-Reply-To: <AANLkTimHmbVbScgDHsb8f=ts0QKr-+pwNm=YY4sG+bz1@mail.gmail.com>
On Wed, Sep 29, 2010 at 10:04:31AM +0200, Kay Sievers wrote:
> On Wed, Sep 29, 2010 at 09:25, Ric Wheeler <rwheeler@redhat.com> wrote:
>
> > Second question is why is checking in /sys a big deal, would ??you prefer an
> > interface like we did for alignment in libblkid?
>
> It's about knowing what's behind the 'nodev' major == 0 of a btrfs
> mount. There is no way to get that from /sys or anywhere else at the
> moment.
>
> Usually filesystems backed by a disk have the dev_t of the device, or
> the fake block devices like md/dm/raid have their own major and the
> slaves/ directory pointing to the devices.
>
> This is not only about readahead, it's every other tool, that needs to
> know what kind of disks are behind a btrfs 'nodev' major == 0 mount.
Thanks for explaining the problem. It's one that affects everything
with more than one underlying block device, so adding a
filesystem-specific ioctl hack is not a good idea. As mentioned in this
mail we already have a solution for that - the block device slaves
links used for raid and volume managers. The most logical fix is to
re-use that for btrfs as well and stop it from abusing the anonymous
block major that was never intended for block based filesystems (and
already has caused trouble in other areas). One way to to this might
be to allocate a block major for btrfs that only gets used for
representing these links.
next prev parent reply other threads:[~2010-09-29 23:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 20:53 [PATCH] Btrfs: add a disk info ioctl to get the disks attached to a filesystem Josef Bacik
2010-09-28 22:28 ` Goffredo Baroncelli
2010-09-29 0:24 ` Josef Bacik
2010-09-28 23:25 ` Christoph Hellwig
2010-09-29 0:08 ` Josef Bacik
2010-09-29 0:19 ` Lennart Poettering
2010-09-29 7:25 ` Ric Wheeler
2010-09-29 8:04 ` Kay Sievers
2010-09-29 23:43 ` Christoph Hellwig [this message]
2010-09-30 0:32 ` Josef Bacik
2010-09-30 7:43 ` Kay Sievers
2010-09-30 12:38 ` Josef Bacik
2010-09-30 13:47 ` Andi Kleen
2010-09-30 19:48 ` Josef Bacik
2010-09-30 19:59 ` Kay Sievers
2010-09-30 20:37 ` Lennart Poettering
2010-09-29 11:59 ` Lennart Poettering
2010-09-29 12:08 ` Ric Wheeler
2010-09-29 12:19 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929234327.GA8401@infradead.org \
--to=hch@infradead.org \
--cc=josef@redhat.com \
--cc=kay.sievers@vrfy.org \
--cc=lennart@poettering.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=rwheeler@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).