linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Cláudio Martins" <ctpm@ist.utl.pt>
To: Josef Bacik <josef@redhat.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs-progs: add support for mixed data+metadata block groups V3
Date: Fri, 29 Oct 2010 01:20:13 +0100	[thread overview]
Message-ID: <20101029012013.68a18b8a.ctpm@ist.utl.pt> (raw)
In-Reply-To: <1288204654-2127-1-git-send-email-josef@redhat.com>


On Wed, 27 Oct 2010 14:37:34 -0400 Josef Bacik <josef@redhat.com> wrote=
:
> So alot of crazy people (I'm looking at you Meego) want to use btrfs =
on phones
> and such with small devices.  Unfortunately the way we split out meta=
data/data
> chunks it makes space usage inefficient for volumes that are smaller =
than
> 1gigabyte.  So add a -M option for mixing metadata+data, and default =
to this
> mixed mode if the filesystem is less than or equal to 1 gigabyte.  I'=
ve tested
> this with xfstests on a 100mb filesystem and everything is a-ok.
>=20

 Hi,

 Could you provide some rationale as to why btrfs should support these
two modes of data/metadata (mixed and separate) allocation instead of
just always doing mixed data+metadata?

 The reason I'm asking this is that having two separate modes implies
having more codepaths in the kernel, which naturally adds complexity to
the filesystem and also more code to test, two things that should be
avoided, if possible. I'd love if you could add a small explanation to
your patch description (or a comment in the code) about why it is
useful to keep the default mode of allocation, instead of simply
droping it and doing mixed allocation in all cases.

 Thanks in advance.

Best regards

Cl=C3=A1udio

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-10-29  0:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-27 18:37 [PATCH] Btrfs-progs: add support for mixed data+metadata block groups V3 Josef Bacik
2010-10-29  0:20 ` Cláudio Martins [this message]
2010-10-29  1:03   ` Josef Bacik
2010-11-06 21:10     ` Mitch Harder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101029012013.68a18b8a.ctpm@ist.utl.pt \
    --to=ctpm@ist.utl.pt \
    --cc=josef@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).