From: Goffredo Baroncelli <kreijack@libero.it>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/5] btrfs: Make async snapshot ioctl more generic
Date: Mon, 29 Nov 2010 20:11:53 +0100 [thread overview]
Message-ID: <201011292011.53426.kreijack@libero.it> (raw)
On Monday, 29 November, 2010, Goffredo Baroncelli wrote:
> Why the unused fields ? What happens if you use a more recent btrfs-tools
> which take advantage of these fields but the kernel is an old one ? At the
> minimum please check the flags so
> (flags^(BTRFS_SNAPSHOT_CREATE_ASYNC|BTRFS_SNAPSHOT_RDONLY)) == 0
> and
> unused[0..3] == 0
Sorry, the check should be
(flags & (~(BTRFS_SNAPSHOT_CREATE_ASYNC|BTRFS_SNAPSHOT_RDONLY))) == 0
>
> For future expansion I suggest to use a different ioctl. To me it seems a
more
> robust API.
>
--
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijack@inwind.it>
Key fingerprint = 4769 7E51 5293 D36C 814E C054 BF04 F161 3DC5 0512
next reply other threads:[~2010-11-29 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 19:11 Goffredo Baroncelli [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-11-29 8:02 [PATCH 0/5] btrfs: Readonly snapshots Li Zefan
2010-11-29 8:02 ` [PATCH 1/5] btrfs: Make async snapshot ioctl more generic Li Zefan
2010-11-29 18:52 ` Goffredo Baroncelli
2010-11-30 1:13 ` Li Zefan
2010-11-29 19:28 ` Sage Weil
2010-12-07 19:04 ` Sage Weil
2010-12-08 1:09 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011292011.53426.kreijack@libero.it \
--to=kreijack@libero.it \
--cc=linux-btrfs@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).