From: Josef Bacik <josef@redhat.com>
To: Miao Xie <miaox@cn.fujitsu.com>
Cc: Josef Bacik <josef@redhat.com>,
Chris Mason <chris.mason@oracle.com>,
Mitch Harder <mitch.harder@sabayonlinux.org>,
Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH V3 1/6] btrfs: fix wrong data space statistics
Date: Wed, 12 Jan 2011 08:49:20 -0500 [thread overview]
Message-ID: <20110112134919.GB2645@localhost.localdomain> (raw)
In-Reply-To: <4D2442D3.6050906@cn.fujitsu.com>
On Wed, Jan 05, 2011 at 06:07:15PM +0800, Miao Xie wrote:
> Josef has implemented mixed data/metadata chunks, we must add those chunks'
> space just like data chunks.
>
> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Reviewed-by: Josef Bacik <josef@redhat.com>
Thanks,
Josef
> ---
> fs/btrfs/super.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
> index 61bd79a..1d21208 100644
> --- a/fs/btrfs/super.c
> +++ b/fs/btrfs/super.c
> @@ -768,11 +768,10 @@ static int btrfs_statfs(struct dentry *dentry, struct kstatfs *buf)
>
> rcu_read_lock();
> list_for_each_entry_rcu(found, head, list) {
> - if (found->flags & (BTRFS_BLOCK_GROUP_METADATA |
> - BTRFS_BLOCK_GROUP_SYSTEM))
> - total_used_data += found->disk_total;
> - else
> + if (found->flags & BTRFS_BLOCK_GROUP_DATA)
> total_used_data += found->disk_used;
> + else
> + total_used_data += found->disk_total;
> total_used += found->disk_used;
> }
> rcu_read_unlock();
> --
> 1.7.2.3
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-01-12 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 10:07 [PATCH V3 1/6] btrfs: fix wrong data space statistics Miao Xie
2011-01-12 13:49 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112134919.GB2645@localhost.localdomain \
--to=josef@redhat.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=mitch.harder@sabayonlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).