From: Josef Bacik <josef@redhat.com>
To: Miao Xie <miaox@cn.fujitsu.com>
Cc: Chris Mason <chris.mason@oracle.com>,
Josef Bacik <josef@redhat.com>,
Mitch Harder <mitch.harder@sabayonlinux.org>,
Linux Btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH V3 3/6] btrfs: fix wrong calculation of stripe size
Date: Wed, 12 Jan 2011 08:51:07 -0500 [thread overview]
Message-ID: <20110112135107.GC2645@localhost.localdomain> (raw)
In-Reply-To: <4D2442DC.1060109@cn.fujitsu.com>
On Wed, Jan 05, 2011 at 06:07:24PM +0800, Miao Xie wrote:
> There are two tiny problem:
> - One is When we check the chunk size is greater than the max chunk size or not,
> we should take mirrors into account, but the original code didn't.
> - The other is btrfs shouldn't use the size of the residual free space as the
> length of of a dup chunk when doing chunk allocation. It is because the device
> space that a dup chunk needs is twice as large as the chunk size, if we use
> the size of the residual free space as the length of a dup chunk, we can not
> get enough free space. Fix it.
>
> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Reviewed-by: Josef Bacik <josef@redhat.com>
Thanks,
Josef
prev parent reply other threads:[~2011-01-12 13:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 10:07 [PATCH V3 3/6] btrfs: fix wrong calculation of stripe size Miao Xie
2011-01-12 13:51 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112135107.GC2645@localhost.localdomain \
--to=josef@redhat.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=mitch.harder@sabayonlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).