From: Tejun Heo <tj@kernel.org>
To: Chris Mason <chris.mason@oracle.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH RFC] btrfs: Simplify locking
Date: Mon, 21 Mar 2011 09:29:42 +0100 [thread overview]
Message-ID: <20110321082942.GD12003@htj.dyndns.org> (raw)
In-Reply-To: <1300665355-sup-1698@think>
Hello, Chris.
On Sun, Mar 20, 2011 at 08:10:51PM -0400, Chris Mason wrote:
> I went through a number of benchmarks with the explicit
> blocking/spinning code and back then it was still significantly faster
> than the adaptive spin. But, it is definitely worth doing these again,
> how many dbench procs did you use?
It was dbench 50.
> The biggest benefit to explicit spinning is that mutex_lock starts with
> might_sleep(), so we skip the cond_resched(). Do you have voluntary
> preempt on?
Ah, right, I of course forgot to actually attach the .config. I had
CONFIG_PREEMPT, not CONFIG_PREEMPT_VOLUNTARY. I'll re-run with
VOLUNTARY and see how its behavior changes.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-03-21 8:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-20 17:44 [PATCH RFC] btrfs: Simplify locking Tejun Heo
2011-03-20 19:56 ` Tejun Heo
2011-03-20 20:17 ` Tejun Heo
2011-03-21 0:10 ` Chris Mason
2011-03-21 8:29 ` Tejun Heo [this message]
2011-03-21 16:59 ` Tejun Heo
2011-03-21 17:11 ` Tejun Heo
2011-03-21 17:24 ` Chris Mason
2011-03-21 18:11 ` Tejun Heo
2011-03-22 23:13 ` Chris Mason
2011-03-23 10:46 ` Tejun Heo
2011-03-23 11:44 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110321082942.GD12003@htj.dyndns.org \
--to=tj@kernel.org \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).