From: Sergei Trofimovich <slyich@gmail.com>
To: liubo <liubo2009@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, Josef Bacik <josef@redhat.com>,
Arne Jansen <sensille@gmx.net>
Subject: Re: [PATCH] Btrfs: fix easily get into ENOSPC in mixed case
Date: Sat, 9 Apr 2011 00:09:32 +0300 [thread overview]
Message-ID: <20110409000932.6154c7b5@sf> (raw)
In-Reply-To: <4D9ECAF5.50108@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 3573 bytes --]
On Fri, 08 Apr 2011 16:44:37 +0800
liubo <liubo2009@cn.fujitsu.com> wrote:
>
> When a btrfs disk is created by mixed data & metadata option, it will have no
> pure data or pure metadata space info.
>
> In btrfs's for-linus branch, commit 78b1ea13838039cd88afdd62519b40b344d6c920
> (Btrfs: fix OOPS of empty filesystem after balance) initializes space infos at
> the very beginning. The problem is this initialization does not take the mixed
> case into account, which will cause btrfs will easily get into ENOSPC in mixed
> case.
>
> Signed-off-by: Liu Bo <liubo2009@cn.fujitsu.com>
> ---
Tried to apply this patch on top of 2.6.39-rc2 and booted on the same partition.
It has 3.2 GBs free. With patch it started to report -ENOSPC right out.
Attempt to delete some files caused OOps:
[ 220.784098] ------------[ cut here ]------------
[ 220.784416] kernel BUG at /mnt/archive/src/linux-2.6/fs/btrfs/inode.c:2962!
[ 220.784700] invalid opcode: 0000 [#1] PREEMPT SMP
[ 220.784969] last sysfs file: /sys/devices/virtual/bdi/0:26/uevent
[ 220.785011] CPU 0
[ 220.785011] Modules linked in: bridge stp llc btrfs zlib_deflate lzo_decompress lzo_compress crc32c libcrc32c tun kvm_amd kvm fuse nouveau ttm drm_kms_helper drm i2c_algo_bit i2c_core cfbcopyarea cfbimgblt 8139cp cfbfillrect 8139too forcedeth
[ 220.785011]
[ 220.785011] Pid: 2881, comm: mc Not tainted 2.6.39-rc2+ #2 To Be Filled By O.E.M. To Be Filled By O.E.M./ALiveNF6G-VSTA
[ 220.785011] RIP: 0010:[<ffffffffa024a141>] [<ffffffffa024a141>] btrfs_unlink+0xd1/0xe0 [btrfs]
[ 220.785011] RSP: 0018:ffff88006898fe28 EFLAGS: 00010286
[ 220.785011] RAX: 00000000ffffffe4 RBX: 00000000ffffffe4 RCX: 0000000000006d32
[ 220.785011] RDX: 0000000000006d30 RSI: 00000000000196d0 RDI: ffffea0001a3d2b8
[ 220.785011] RBP: ffff88006898fe58 R08: ffffffffa021e02a R09: ffff88006898fb48
[ 220.785011] R10: ffffffffffffffe4 R11: 0000000000000001 R12: ffff88005b5e2540
[ 220.785011] R13: ffff88005b668040 R14: ffff880077344800 R15: ffff88005b674578
[ 220.785011] FS: 00007f8587265700(0000) GS:ffff88007bc00000(0000) knlGS:0000000000000000
[ 220.785011] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[ 220.785011] CR2: 00007f8587277000 CR3: 0000000068a29000 CR4: 00000000000006f0
[ 220.785011] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 220.785011] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 220.785011] Process mc (pid: 2881, threadinfo ffff88006898e000, task ffff880070a64230)
[ 220.785011] Stack:
[ 220.785011] ffff88006898fe48 00000000fffffff0 ffff88005b5e2540 ffff88005b674198
[ 220.785011] 0000000000000000 00007fff6ee8d6b0 ffff88006898fe88 ffffffff810ed420
[ 220.785011] ffff88006898fe88 ffff88006898fe98 ffff88005b5e2540 ffff88005b674578
[ 220.785011] Call Trace:
[ 220.785011] [<ffffffff810ed420>] vfs_unlink+0x80/0xf0
[ 220.785011] [<ffffffff810ef773>] do_unlinkat+0x173/0x1b0
[ 220.785011] [<ffffffff81051a88>] ? sys_rt_sigaction+0x68/0xc0
[ 220.785011] [<ffffffff810f0cc1>] sys_unlink+0x11/0x20
[ 220.785011] [<ffffffff81574bbb>] system_call_fastpath+0x16/0x1b
[ 220.785011] Code: 4c 8b 65 e0 48 8b 5d d8 4c 8b 6d e8 4c 8b 75 f0 4c 8b 7d f8 c9 c3 0f 1f 40 00 4c 89 fe 4c 89 ef e8 25 d0 ff ff 85 c0 74 bb 0f 0b <0f> 0b 89 c3 eb cd 66 0f 1f 84 00 00 00 00 00 55 48 89 e5 41 57
[ 220.785011] RIP [<ffffffffa024a141>] btrfs_unlink+0xd1/0xe0 [btrfs]
[ 220.785011] RSP <ffff88006898fe28>
[ 220.809847] ---[ end trace ca8cb79df9da2e2a ]---
--
Sergei
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-04-08 21:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-02 9:19 2.6.39-rc1: kernel BUG at fs/btrfs/extent-tree.c:5479! Sergei Trofimovich
2011-04-02 9:37 ` liubo
2011-04-02 10:41 ` Sergei Trofimovich
2011-04-02 11:30 ` liubo
2011-04-02 12:55 ` Sergei Trofimovich
2011-04-08 8:44 ` [PATCH] Btrfs: fix easily get into ENOSPC in mixed case liubo
2011-04-08 21:09 ` Sergei Trofimovich [this message]
2011-04-08 21:19 ` Sergei Trofimovich
2011-04-08 21:55 ` Sergei Trofimovich
2011-04-11 6:29 ` liubo
2011-04-11 20:27 ` Sergei Trofimovich
2011-04-19 21:55 ` Sergei Trofimovich
2011-04-21 15:19 ` Sergei Trofimovich
2011-04-22 19:43 ` Sergei Trofimovich
2011-05-05 14:44 ` Sergei Trofimovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110409000932.6154c7b5@sf \
--to=slyich@gmail.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
--cc=sensille@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).