From: Sergei Trofimovich <slyich@gmail.com>
To: Sergei Trofimovich <slyich@gmail.com>
Cc: liubo <liubo2009@cn.fujitsu.com>,
linux-btrfs@vger.kernel.org, Josef Bacik <josef@redhat.com>,
Arne Jansen <sensille@gmx.net>
Subject: Re: [PATCH] Btrfs: fix easily get into ENOSPC in mixed case
Date: Sat, 9 Apr 2011 00:55:55 +0300 [thread overview]
Message-ID: <20110409005555.4b136f25@sf> (raw)
In-Reply-To: <20110409001920.089c4409@sf>
[-- Attachment #1: Type: text/plain, Size: 6319 bytes --]
> > > In btrfs's for-linus branch, commit 78b1ea13838039cd88afdd62519b40b344d6c920
> > > (Btrfs: fix OOPS of empty filesystem after balance) initializes space infos at
> > > the very beginning. The problem is this initialization does not take the mixed
> > > case into account, which will cause btrfs will easily get into ENOSPC in mixed
> > > case.
> > >
> > > Signed-off-by: Liu Bo <liubo2009@cn.fujitsu.com>
> > > ---
> Sorry, I was too fast. The same OOps is reproducible on vanilla 2.6.39-rc2. Will retest on 2.6.39-rc1.
2.6.39-rc1 (no patch):
[ 155.038094] ------------[ cut here ]------------
[ 155.038388] kernel BUG at /mnt/archive/src/linux-2.6/fs/btrfs/inode.c:2967!
[ 155.038643] invalid opcode: 0000 [#1] PREEMPT SMP
[ 155.038907] last sysfs file: /sys/devices/virtual/bdi/0:26/uevent
[ 155.039011] CPU 0
[ 155.039011] Modules linked in: bridge stp llc btrfs zlib_deflate lzo_decompress lzo_compress crc32c libcrc32c tun kvm_amd kvm fuse nouveau ttm 8139cp drm_kms_helper drm i2c_algo_bit i2c_core cfbcopyarea cfbimgblt cfbfillrect 8139too forcedeth
[ 155.039011]
[ 155.039011] Pid: 2620, comm: rm Not tainted 2.6.39-rc1 #3 To Be Filled By O.E.M. To Be Filled By O.E.M./ALiveNF6G-VSTA
[ 155.039011] RIP: 0010:[<ffffffffa0249fd1>] [<ffffffffa0249fd1>] btrfs_unlink+0xd1/0xe0 [btrfs]
[ 155.039011] RSP: 0018:ffff880073687e28 EFLAGS: 00010286
[ 155.039011] RAX: 00000000ffffffe4 RBX: 00000000ffffffe4 RCX: 00000000000000e0
[ 155.039011] RDX: 00000000000000de RSI: 00000000000196d0 RDI: ffffea0001a3d980
[ 155.039011] RBP: ffff880073687e58 R08: ffffffffa021df4a R09: ffff880073687b48
[ 155.039011] R10: ffffffffffffffe4 R11: 0000000000000001 R12: ffff8800756eab40
[ 155.039011] R13: ffff8800756eb000 R14: ffff880075e8e800 R15: ffff880077f7e858
[ 155.039011] FS: 00007f99bdd9c700(0000) GS:ffff88007bc00000(0000) knlGS:0000000000000000
[ 155.039011] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[ 155.039011] CR2: 00007f99be7480a8 CR3: 0000000073610000 CR4: 00000000000006f0
[ 155.039011] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 155.039011] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 155.039011] Process rm (pid: 2620, threadinfo ffff880073686000, task ffff8800730cc230)
[ 155.039011] Stack:
[ 155.039011] ffff880073687e48 00000000fffffff0 ffff8800756eab40 ffff880077f7e478
[ 155.039011] 0000000000000000 0000000000000000 ffff880073687e88 ffffffff810ed3a0
[ 155.039011] ffff880073687e88 ffff880073687e98 ffff8800756eab40 ffff880077f7e858
[ 155.039011] Call Trace:
[ 155.039011] [<ffffffff810ed3a0>] vfs_unlink+0x80/0xf0
[ 155.039011] [<ffffffff810ef6f3>] do_unlinkat+0x173/0x1b0
[ 155.039011] [<ffffffff8111727b>] ? fsnotify_find_inode_mark+0x3b/0x50
[ 155.039011] [<ffffffff810dff91>] ? filp_close+0x61/0x90
[ 155.039011] [<ffffffff810f0c0d>] sys_unlinkat+0x1d/0x40
[ 155.039011] [<ffffffff81574c3b>] system_call_fastpath+0x16/0x1b
[ 155.039011] Code: 4c 8b 65 e0 48 8b 5d d8 4c 8b 6d e8 4c 8b 75 f0 4c 8b 7d f8 c9 c3 0f 1f 40 00 4c 89 fe 4c 89 ef e8 05 d0 ff ff 85 c0 74 bb 0f 0b <0f> 0b 89 c3 eb cd 66 0f 1f 84 00 00 00 00 00 55 48 89 e5 41 57
[ 155.039011] RIP [<ffffffffa0249fd1>] btrfs_unlink+0xd1/0xe0 [btrfs]
[ 155.039011] RSP <ffff880073687e28>
[ 155.064611] ---[ end trace 47dc7dae76c74a2a ]---
2.6.39-rc1 (+patch):
[ 100.499105] ------------[ cut here ]------------
[ 100.499405] kernel BUG at /mnt/archive/src/linux-2.6/fs/btrfs/inode.c:2967!
[ 100.499686] invalid opcode: 0000 [#1] PREEMPT SMP
[ 100.499948] last sysfs file: /sys/devices/virtual/bdi/0:26/uevent
[ 100.500011] CPU 1
[ 100.500011] Modules linked in: bridge stp llc btrfs zlib_deflate lzo_decompress lzo_compress crc32c libcrc32c tun kvm_amd kvm fuse nouveau ttm drm_kms_helper drm i2c_algo_bit i2c_core cfbcopyarea cfbimgblt cfbfillrect forcedeth 8139cp 8139too
[ 100.500011]
[ 100.500011] Pid: 2447, comm: rm Not tainted 2.6.39-rc1+ #4 To Be Filled By O.E.M. To Be Filled By O.E.M./ALiveNF6G-VSTA
[ 100.500011] RIP: 0010:[<ffffffffa024a011>] [<ffffffffa024a011>] btrfs_unlink+0xd1/0xe0 [btrfs]
[ 100.500011] RSP: 0018:ffff880070b55e28 EFLAGS: 00010286
[ 100.500011] RAX: 00000000ffffffe4 RBX: 00000000ffffffe4 RCX: 0000000000000013
[ 100.500011] RDX: 0000000000000011 RSI: 00000000000196d0 RDI: ffffea00019aef80
[ 100.500011] RBP: ffff880070b55e58 R08: ffffffffa021df4a R09: ffff880070b55b48
[ 100.500011] R10: ffffffffffffffe4 R11: 0000000000000001 R12: ffff8800756a0c00
[ 100.500011] R13: ffff880075692000 R14: ffff880075e3c800 R15: ffff880077f5e478
[ 100.500011] FS: 00007f01e95c5700(0000) GS:ffff88007bd00000(0000) knlGS:0000000000000000
[ 100.500011] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[ 100.500011] CR2: 00007fd0687a8ec4 CR3: 0000000070b29000 CR4: 00000000000006e0
[ 100.500011] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 100.500011] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[ 100.500011] Process rm (pid: 2447, threadinfo ffff880070b54000, task ffff8800709cc230)
[ 100.500011] Stack:
[ 100.500011] ffff880070b55e48 00000000fffffff0 ffff8800756a0c00 ffff880077f5e098
[ 100.500011] 0000000000000000 0000000000000000 ffff880070b55e88 ffffffff810ed3a0
[ 100.500011] ffff880070b55e88 ffff880070b55e98 ffff8800756a0c00 ffff880077f5e478
[ 100.500011] Call Trace:
[ 100.500011] [<ffffffff810ed3a0>] vfs_unlink+0x80/0xf0
[ 100.500011] [<ffffffff810ef6f3>] do_unlinkat+0x173/0x1b0
[ 100.500011] [<ffffffff8111727b>] ? fsnotify_find_inode_mark+0x3b/0x50
[ 100.500011] [<ffffffff810dff91>] ? filp_close+0x61/0x90
[ 100.500011] [<ffffffff810f0c0d>] sys_unlinkat+0x1d/0x40
[ 100.500011] [<ffffffff81574c3b>] system_call_fastpath+0x16/0x1b
[ 100.500011] Code: 4c 8b 65 e0 48 8b 5d d8 4c 8b 6d e8 4c 8b 75 f0 4c 8b 7d f8 c9 c3 0f 1f 40 00 4c 89 fe 4c 89 ef e8 05 d0 ff ff 85 c0 74 bb 0f 0b <0f> 0b 89 c3 eb cd 66 0f 1f 84 00 00 00 00 00 55 48 89 e5 41 57
[ 100.500011] RIP [<ffffffffa024a011>] btrfs_unlink+0xd1/0xe0 [btrfs]
[ 100.500011] RSP <ffff880070b55e28>
[ 100.525672] ---[ end trace 7e63b9144b7307fe ]---
Looks like I won't be able to test your patch until this thing will go away first.
--
Sergei
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-04-08 21:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-02 9:19 2.6.39-rc1: kernel BUG at fs/btrfs/extent-tree.c:5479! Sergei Trofimovich
2011-04-02 9:37 ` liubo
2011-04-02 10:41 ` Sergei Trofimovich
2011-04-02 11:30 ` liubo
2011-04-02 12:55 ` Sergei Trofimovich
2011-04-08 8:44 ` [PATCH] Btrfs: fix easily get into ENOSPC in mixed case liubo
2011-04-08 21:09 ` Sergei Trofimovich
2011-04-08 21:19 ` Sergei Trofimovich
2011-04-08 21:55 ` Sergei Trofimovich [this message]
2011-04-11 6:29 ` liubo
2011-04-11 20:27 ` Sergei Trofimovich
2011-04-19 21:55 ` Sergei Trofimovich
2011-04-21 15:19 ` Sergei Trofimovich
2011-04-22 19:43 ` Sergei Trofimovich
2011-05-05 14:44 ` Sergei Trofimovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110409005555.4b136f25@sf \
--to=slyich@gmail.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
--cc=sensille@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).