From: David Sterba <dave@jikos.cz>
To: Josef Bacik <josef@redhat.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: avoid taking the chunk_mutex in do_chunk_alloc
Date: Tue, 12 Apr 2011 17:36:43 +0200 [thread overview]
Message-ID: <20110412153643.GI31675@twin.jikos.cz> (raw)
In-Reply-To: <1302568224-4567-1-git-send-email-josef@redhat.com>
Hi,
On Mon, Apr 11, 2011 at 08:30:24PM -0400, Josef Bacik wrote:
> diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
> index 0d00a07..a566780 100644
> --- a/fs/btrfs/ctree.h
> +++ b/fs/btrfs/ctree.h
> @@ -740,10 +740,11 @@ struct btrfs_space_info {
> */
> unsigned long reservation_progress;
>
> - int full; /* indicates that we cannot allocate any more
> + int full:1; /* indicates that we cannot allocate any more
> chunks for this space */
> - int force_alloc; /* set if we need to force a chunk alloc for
> + int force_alloc:1; /* set if we need to force a chunk alloc for
> this space */
> + int chunk_alloc:1; /* set if we are allocating a chunk */
>
> struct list_head list;
>
please make the bitfields unsigned.
david
prev parent reply other threads:[~2011-04-12 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 0:30 [PATCH] Btrfs: avoid taking the chunk_mutex in do_chunk_alloc Josef Bacik
2011-04-12 1:33 ` liubo
2011-04-12 12:42 ` Josef Bacik
2011-04-13 12:11 ` David Sterba
2011-04-12 15:36 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412153643.GI31675@twin.jikos.cz \
--to=dave@jikos.cz \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox