From: David Miller <davem@davemloft.net>
To: dave@jikos.cz
Cc: seb@frankengul.org, linux-btrfs@vger.kernel.org,
sparclinux@vger.kernel.org, debian-sparc@lists.debian.org
Subject: Re: Warning when mounting btrfs partition, kernel unaligned access
Date: Wed, 13 Apr 2011 10:48:31 -0700 (PDT) [thread overview]
Message-ID: <20110413.104831.189703153.davem@davemloft.net> (raw)
In-Reply-To: <20110413094037.GL31675@twin.jikos.cz>
=46rom: David Sterba <dave@jikos.cz>
Date: Wed, 13 Apr 2011 11:40:37 +0200
> On Wed, Apr 13, 2011 at 01:03:56AM +0200, S=E9bastien Bernard wrote:
>> Then, after writing on the disk, I got a lot of warning:
>> [ 822.515875] Kernel unaligned access at TPC[103c2204]
>>=20
>> I peeked a look at the btrf_csum_final and here's the function :
>> void btrfs_csum_final(u32 crc, char *result)
>> {
>> *(__le32 *)result =3D ~cpu_to_le32(crc);
>> }
>=20
> FYI, this has been fixed and is already merged into Linus' tree. Comm=
it
> 7e75bf3ff3a716d7b21d8fb43bf823115801c1e9.
Might I suggest adding a BUG_ON() validation of the alignment or
similar here?
You can make the test really cheap, and this way no matter what kind
of systems the btrfs folks do their testing on this kind of regression
will be spotted fast.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" i=
n
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-04-13 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 23:03 Warning when mounting btrfs partition, kernel unaligned access Sébastien Bernard
2011-04-13 5:21 ` Kjetil Oftedal
2011-04-13 9:40 ` David Sterba
2011-04-13 17:48 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110413.104831.189703153.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dave@jikos.cz \
--cc=debian-sparc@lists.debian.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=seb@frankengul.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).