From: Diego <diegocg@gmail.com>
To: Hugo Mills <hugo@carfax.org.uk>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Improve error stats message
Date: Wed, 07 Mar 2018 20:02:51 +0100 [thread overview]
Message-ID: <2011051.lkSedfDimf@archlinux> (raw)
In-Reply-To: <20180307182453.GF20688@carfax.org.uk>
El miércoles, 7 de marzo de 2018 19:24:53 (CET) Hugo Mills escribió:
> On multi-device filesystems, the two are not necessarily the same.
Ouch. FWIW, I was moved to do this because I saw this conversation on
IRC which made me think that people aren't understanding what the
message means:
<nick1> hi! I noticed bdev rd 13 as a kernel message
<nick1> what does it mean
<nick2> Well, that's not the whole message.
<nick2> Can you paste the whole line in here? (Just one line)
<nick1> [ 3.404959] BTRFS info (device sda4): bdev /dev/sda4 errs: wr 0, rd 13, flush 0, corrupt 0, gen 0
Maybe something like this would be better:
BTRFS info (device sda4): disk /dev/sda4 errors: write 0, read 13, flush 0, corrupt 0, generation 0
---
fs/btrfs/volumes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 2ceb924ca0d6..cfa029468585 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -7239,7 +7239,7 @@ static void btrfs_dev_stat_print_on_error(struct btrfs_device *dev)
if (!dev->dev_stats_valid)
return;
btrfs_err_rl_in_rcu(dev->fs_info,
- "bdev %s errs: wr %u, rd %u, flush %u, corrupt %u, gen %u",
+ "disk %s errors: write %u, read %u, flush %u, corrupt %u, generation %u",
rcu_str_deref(dev->name),
btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_WRITE_ERRS),
btrfs_dev_stat_read(dev, BTRFS_DEV_STAT_READ_ERRS),
--
2.16.2
next prev parent reply other threads:[~2018-03-07 19:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 17:37 [PATCH] Improve error stats message Diego
2018-03-07 18:24 ` Hugo Mills
2018-03-07 19:02 ` Diego [this message]
2018-03-07 20:35 ` Hugo Mills
2018-03-08 7:28 ` Nikolay Borisov
2018-03-08 10:04 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2011051.lkSedfDimf@archlinux \
--to=diegocg@gmail.com \
--cc=hugo@carfax.org.uk \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).