From: Mark Fasheh <mfasheh@suse.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>,
Chris Mason <chris.mason@oracle.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC][PATCH 1/2] vfs: allow /proc/pid/maps to return a custom device
Date: Thu, 19 May 2011 13:18:26 -0700 [thread overview]
Message-ID: <20110519201826.GN17822@wotan.suse.de> (raw)
In-Reply-To: <m1tycwk6hv.fsf@fess.ebiederm.org>
On Sat, May 14, 2011 at 08:06:04PM -0700, Eric W. Biederman wrote:
> Mark Fasheh <mfasheh@suse.com> writes:
>
> > This patch introduces a callback in the super_operations structure,
> > 'get_maps_dev' which is then used by procfs to query which device to return
> > for reporting in /proc/[PID]/maps.
>
> No.
>
> It may make sense to call the vfs stat method. But introducing an extra
> vfs operations for this seems like a maintenance nightmare.
Yeah I'm not thrilled with the extra method either. My concern with using
->getattr is whether it's too heavy since that implies potential disk /
network i/o.
--Mark
--
Mark Fasheh
next prev parent reply other threads:[~2011-05-19 20:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 23:18 [RFC][PATCH 0/2] btrfs/vfs: Return same device in stat(2) and /proc/pid/maps Mark Fasheh
2011-05-13 23:18 ` [RFC][PATCH 1/2] vfs: allow /proc/pid/maps to return a custom device Mark Fasheh
2011-05-15 3:06 ` Eric W. Biederman
2011-05-19 20:18 ` Mark Fasheh [this message]
2011-10-07 18:32 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519201826.GN17822@wotan.suse.de \
--to=mfasheh@suse.com \
--cc=chris.mason@oracle.com \
--cc=ebiederm@xmission.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).