linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hugo Mills <hugo-lkml@carfax.org.uk>
To: Mitch Harder <mitch.harder@sabayonlinux.org>,
	dave@jikos.cz, Stephen Rothwell <sfr@canb.auug.org.au>,
	Chris Mason <chris.mason@oracle.com>,
	linux-next@vger.kernel.org, linux-kernel@vg
Subject: Re: linux-next: build warninga in Linus' tree
Date: Fri, 3 Jun 2011 12:38:42 +0100	[thread overview]
Message-ID: <20110603113842.GA10842@carfax.org.uk> (raw)
In-Reply-To: <20110603111048.GR12709@twin.jikos.cz>

[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]

On Fri, Jun 03, 2011 at 01:10:49PM +0200, David Sterba wrote:
> On Wed, Jun 01, 2011 at 10:16:48AM -0500, Mitch Harder wrote:
> > I've been playing around with resurrecting the basic sysfs
> > capabilities that had been previously incorporated into btrfs.
> > 
> > As it stands right now, it was relatively easy to re-implement sysfs
> > as it was originally.  However, that implementation of sysfs wasn't
> > populated with much information (only total_blocks, blocks_used, and
> > blocksize).
> 
> Goffredo Baroncelli (CCed) posted a patch to enhance sysfs interface:
> 
> https://patchwork.kernel.org/patch/308902/
> (http://www.spinics.net/lists/linux-btrfs/msg06777.html)
> 
> > I also had to reverse a small portion of code that was in the last
> > clean-up.
> 
> Restoring the code should not be a problem, the cleanup was too eager
> and I think a sysfs inteface would be good, not only for debugging
> purposes or tuning.

   Indeed. There's a few parts of the balance API that would be
significantly enhanced by being able to put things in sysfs. I could
drop at least one (if not two) of the three ioctls if I had somewhere
in sysfs to put the relevant files.

   Hugo.

-- 
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
  PGP key: 515C238D from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
  --- The glass is neither half-full nor half-empty; it is twice as ---  
                        large as it needs to be.                         

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

  reply	other threads:[~2011-06-03 11:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-30  1:36 linux-next: build warninga in Linus' tree Stephen Rothwell
2011-05-31 17:57 ` David Sterba
2011-06-01 15:16   ` Mitch Harder
2011-06-03 11:10     ` David Sterba
2011-06-03 11:38       ` Hugo Mills [this message]
2011-06-03 13:16       ` Greg KH
2011-06-03 13:16       ` Greg KH
2011-06-03 12:25 ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110603113842.GA10842@carfax.org.uk \
    --to=hugo-lkml@carfax.org.uk \
    --cc=chris.mason@oracle.com \
    --cc=dave@jikos.cz \
    --cc=linux-kernel@vg \
    --cc=linux-next@vger.kernel.org \
    --cc=mitch.harder@sabayonlinux.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).