From: Chris Mason <chris.mason@oracle.com>
To: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: new metadata reader/writer locks in integration-test
Date: Fri, 22 Jul 2011 11:49:15 -0400 [thread overview]
Message-ID: <20110722154915.GA15194@shiny> (raw)
In-Reply-To: <4E269379.20405@jp.fujitsu.com>
On Wed, Jul 20, 2011 at 05:36:09PM +0900, Tsutomu Itoh wrote:
> (2011/07/20 16:58), Chris Mason wrote:
> > Excerpts from Tsutomu Itoh's message of 2011-07-19 22:08:38 -0400:
> >> (2011/07/20 2:30), Chris Mason wrote:
> >>> Hi everyone,
> >>>
> >>> I've pushed out a new integration-test branch, and it includes a new
> >>> reader/writer locking scheme for the btree locks.
> >>>
> >>> We've seen a number of benchmarks dominated by contention on the root
> >>> node lock. This changes our locks into a simple reader/writer lock.
> >>> They are based on mutexes so that we still take advantage of the mutex
> >>> adaptive spins for write locks (rwsemaphores were much slower).
> >>>
> >>> I'm also sending the individual commits, please do take a look.
> >>
> >> I pulled the new integration-test branch, and I got the following
> >> warning messages.
> >>
> >> Jul 20 10:03:30 luna kernel: ------------[ cut here ]------------
> >> Jul 20 10:03:30 luna kernel: WARNING: at fs/btrfs/extent-tree.c:5704 btrfs_alloc_free_block+0x178/0x340 [btrfs]()
> >
> > Thanks, I think this one is related to Josef's enospc changes, but I'll
> > double check.
>
> >What was the test?
>
> I ran my original test script.
> This script concurrently executes the making deletion of a lot of files,
> and the making deletion of a big file, etc.
I'm having a hard time triggering this with Josef's current patch (after
my rebase).
Could you please send along the reproduction script?
-chris
next prev parent reply other threads:[~2011-07-22 15:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 17:30 new metadata reader/writer locks in integration-test Chris Mason
2011-07-20 2:08 ` Tsutomu Itoh
2011-07-20 7:58 ` Chris Mason
2011-07-20 8:36 ` Tsutomu Itoh
2011-07-22 15:49 ` Chris Mason [this message]
2011-07-20 6:55 ` Arne Jansen
2011-07-20 16:49 ` Arne Jansen
2011-07-20 17:21 ` Chris Mason
2011-07-20 18:51 ` Chris Mason
2011-07-21 4:54 ` Li Zefan
2011-07-21 0:48 ` Tsutomu Itoh
2011-07-21 5:46 ` Arne Jansen
2011-07-22 0:53 ` Chris Mason
2011-07-22 4:06 ` Miao Xie
2011-07-22 9:12 ` Miao Xie
2011-07-21 5:44 ` Arne Jansen
2011-07-22 15:58 ` Arne Jansen
2011-07-22 15:01 ` rw_semaphore performance, was: " Christoph Hellwig
2011-07-22 15:14 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110722154915.GA15194@shiny \
--to=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=t-itoh@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).