* autodegrag: WARNING: at fs/inode.c:1315 iput+0x20b/0x210()
@ 2011-08-26 20:18 Sergei Trofimovich
2011-08-27 14:15 ` Sergei Trofimovich
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Trofimovich @ 2011-08-26 20:18 UTC (permalink / raw)
To: linux-btrfs
[-- Attachment #1: Type: text/plain, Size: 2602 bytes --]
I used 3.1.0-rc2+ kernel for some weeks before without any dmesg warnings.
I've decided to enable autodegrag feature for my btrfs / today and got
warning in $SUBJ.
It's an:
> static void iput_final(struct inode *inode)
> ...
> WARN_ON(inode->i_state & I_NEW);
Looks scary. Tried latest mainline kernel and got the same warning.
The issue does not seem to appear at once.
How do I reproduce it:
- boot to the kernel
- start Xorg
- run liferea and firefox at once (parallel or just heavy write load?)
- get warnings in dmesg (a ton of them):
Aug 26 23:07:21 sf kernel: [ 204.268669] ------------[ cut here ]------------
Aug 26 23:07:21 sf kernel: [ 204.268685] WARNING: at fs/inode.c:1315 iput+0x20b/0x210()
Aug 26 23:07:21 sf kernel: [ 204.268689] Hardware name: HP Compaq 2510p Notebook PC
Aug 26 23:07:21 sf kernel: [ 204.268692] Modules linked in: ext2 loop kvm_intel kvm fuse scsi_wait_scan usb_storage tun sdhci_
pci yenta_socket sdhci pcmcia_core thermal mmc_core iwl4965 iwl_legacy mac80211 pcmcia_rsrc ac fan processor cfg80211 e1000e sn
d_hda_codec_analog rfkill container battery i915 drm_kms_helper drm snd_hda_intel i2c_algo_bit snd_hda_codec button snd_hwdep
Aug 26 23:07:21 sf kernel: [ 204.268753] Pid: 715, comm: btrfs-cleaner Tainted: G W 3.1.0-rc3-00202-g96d185c #138
Aug 26 23:07:21 sf kernel: [ 204.268758] Call Trace:
Aug 26 23:07:21 sf kernel: [ 204.268769] [<ffffffff8103e7ba>] warn_slowpath_common+0x7a/0xb0
Aug 26 23:07:21 sf kernel: [ 204.268776] [<ffffffff8103e805>] warn_slowpath_null+0x15/0x20
Aug 26 23:07:21 sf kernel: [ 204.268781] [<ffffffff810eafbb>] iput+0x20b/0x210
Aug 26 23:07:21 sf kernel: [ 204.268789] [<ffffffff811b990b>] btrfs_iget+0x1eb/0x4a0
Aug 26 23:07:21 sf kernel: [ 204.268797] [<ffffffff811c3ce6>] btrfs_run_defrag_inodes+0x136/0x210
Aug 26 23:07:21 sf kernel: [ 204.268803] [<ffffffff811ad76f>] cleaner_kthread+0x17f/0x1a0
Aug 26 23:07:21 sf kernel: [ 204.268810] [<ffffffff81035b7d>] ? sub_preempt_count+0x9d/0xd0
Aug 26 23:07:21 sf kernel: [ 204.268816] [<ffffffff811ad5f0>] ? transaction_kthread+0x280/0x280
Aug 26 23:07:21 sf kernel: [ 204.268822] [<ffffffff8105b056>] kthread+0x96/0xa0
Aug 26 23:07:21 sf kernel: [ 204.268830] [<ffffffff81433914>] kernel_thread_helper+0x4/0x10
Aug 26 23:07:21 sf kernel: [ 204.268836] [<ffffffff8105afc0>] ? kthread_worker_fn+0x190/0x190
Aug 26 23:07:21 sf kernel: [ 204.268842] [<ffffffff81433910>] ? gs_change+0xb/0xb
Aug 26 23:07:21 sf kernel: [ 204.268846] ---[ end trace 495191005b4af701 ]---
Thanks!
--
Sergei
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: autodegrag: WARNING: at fs/inode.c:1315 iput+0x20b/0x210()
2011-08-26 20:18 autodegrag: WARNING: at fs/inode.c:1315 iput+0x20b/0x210() Sergei Trofimovich
@ 2011-08-27 14:15 ` Sergei Trofimovich
2011-08-28 8:49 ` Sergei Trofimovich
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Trofimovich @ 2011-08-27 14:15 UTC (permalink / raw)
To: linux-btrfs
[-- Attachment #1: Type: text/plain, Size: 1947 bytes --]
On Fri, 26 Aug 2011 23:18:44 +0300
Sergei Trofimovich <slyich@gmail.com> wrote:
> I used 3.1.0-rc2+ kernel for some weeks before without any dmesg warnings.
> I've decided to enable autodegrag feature for my btrfs / today and got
> warning in $SUBJ.
>
> It's an:
> > static void iput_final(struct inode *inode)
> > ...
> > WARN_ON(inode->i_state & I_NEW);
>
If you prefer nontainted kernel report (without unrelated warnings):
[ 282.380849] ------------[ cut here ]------------
[ 282.380865] WARNING: at fs/inode.c:1315 iput+0x20b/0x210()
[ 282.380869] Hardware name: HP Compaq 2510p Notebook PC
[ 282.380873] Modules linked in: ext2 loop kvm_intel kvm fuse scsi_wait_scan usb_storage tun i915 drm_kms_helper drm yenta_socket sdhci_pci sdhci snd_hda_codec_analog iwl4965 mmc_core i2c_algo_bit pcmcia_core thermal container ac button fan battery e1000e iwl_legacy mac80211 snd_hda_intel cfg80211 snd_hda_codec pcmcia_rsrc processor rfkill snd_hwdep
[ 282.380932] Pid: 715, comm: btrfs-cleaner Not tainted 3.1.0-rc3-00203-gdbf2e46 #139
[ 282.380936] Call Trace:
[ 282.380947] [<ffffffff8103e7ba>] warn_slowpath_common+0x7a/0xb0
[ 282.380954] [<ffffffff8103e805>] warn_slowpath_null+0x15/0x20
[ 282.380960] [<ffffffff810eafbb>] iput+0x20b/0x210
[ 282.380967] [<ffffffff811b990b>] btrfs_iget+0x1eb/0x4a0
[ 282.380975] [<ffffffff811c3ce6>] btrfs_run_defrag_inodes+0x136/0x210
[ 282.380982] [<ffffffff811ad76f>] cleaner_kthread+0x17f/0x1a0
[ 282.380988] [<ffffffff81035b7d>] ? sub_preempt_count+0x9d/0xd0
[ 282.380994] [<ffffffff811ad5f0>] ? transaction_kthread+0x280/0x280
[ 282.381001] [<ffffffff8105b056>] kthread+0x96/0xa0
[ 282.381027] [<ffffffff81433914>] kernel_thread_helper+0x4/0x10
[ 282.381034] [<ffffffff8105afc0>] ? kthread_worker_fn+0x190/0x190
[ 282.381039] [<ffffffff81433910>] ? gs_change+0xb/0xb
[ 282.381044] ---[ end trace 40720e359a3c0fea ]---
--
Sergei
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: autodegrag: WARNING: at fs/inode.c:1315 iput+0x20b/0x210()
2011-08-27 14:15 ` Sergei Trofimovich
@ 2011-08-28 8:49 ` Sergei Trofimovich
2011-08-29 19:19 ` Sergei Trofimovich
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Trofimovich @ 2011-08-28 8:49 UTC (permalink / raw)
To: linux-btrfs
[-- Attachment #1: Type: text/plain, Size: 1637 bytes --]
> [ 282.380849] ------------[ cut here ]------------
> [ 282.380865] WARNING: at fs/inode.c:1315 iput+0x20b/0x210()
> [ 282.380869] Hardware name: HP Compaq 2510p Notebook PC
> [ 282.380873] Modules linked in: ext2 loop kvm_intel kvm fuse scsi_wait_scan usb_storage tun i915 drm_kms_helper drm yenta_socket sdhci_pci sdhci snd_hda_codec_analog iwl4965 mmc_core i2c_algo_bit pcmcia_core thermal container ac button fan battery e1000e iwl_legacy mac80211 snd_hda_intel cfg80211 snd_hda_codec pcmcia_rsrc processor rfkill snd_hwdep
> [ 282.380932] Pid: 715, comm: btrfs-cleaner Not tainted 3.1.0-rc3-00203-gdbf2e46 #139
> [ 282.380936] Call Trace:
> [ 282.380947] [<ffffffff8103e7ba>] warn_slowpath_common+0x7a/0xb0
> [ 282.380954] [<ffffffff8103e805>] warn_slowpath_null+0x15/0x20
> [ 282.380960] [<ffffffff810eafbb>] iput+0x20b/0x210
> [ 282.380967] [<ffffffff811b990b>] btrfs_iget+0x1eb/0x4a0
> [ 282.380975] [<ffffffff811c3ce6>] btrfs_run_defrag_inodes+0x136/0x210
> [ 282.380982] [<ffffffff811ad76f>] cleaner_kthread+0x17f/0x1a0
> [ 282.380988] [<ffffffff81035b7d>] ? sub_preempt_count+0x9d/0xd0
> [ 282.380994] [<ffffffff811ad5f0>] ? transaction_kthread+0x280/0x280
> [ 282.381001] [<ffffffff8105b056>] kthread+0x96/0xa0
> [ 282.381027] [<ffffffff81433914>] kernel_thread_helper+0x4/0x10
> [ 282.381034] [<ffffffff8105afc0>] ? kthread_worker_fn+0x190/0x190
> [ 282.381039] [<ffffffff81433910>] ? gs_change+0xb/0xb
> [ 282.381044] ---[ end trace 40720e359a3c0fea ]---
Konstantin's patch
[PATCH] btrfs: fix warning in iput for bad-inode
fixed the issue.
--
Sergei
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: autodegrag: WARNING: at fs/inode.c:1315 iput+0x20b/0x210()
2011-08-28 8:49 ` Sergei Trofimovich
@ 2011-08-29 19:19 ` Sergei Trofimovich
0 siblings, 0 replies; 4+ messages in thread
From: Sergei Trofimovich @ 2011-08-29 19:19 UTC (permalink / raw)
To: linux-btrfs
[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]
> > [ 282.380849] ------------[ cut here ]------------
> > [ 282.380865] WARNING: at fs/inode.c:1315 iput+0x20b/0x210()
> > [ 282.380869] Hardware name: HP Compaq 2510p Notebook PC
> > [ 282.380873] Modules linked in: ext2 loop kvm_intel kvm fuse scsi_wait_scan usb_storage tun i915 drm_kms_helper drm yenta_socket sdhci_pci sdhci snd_hda_codec_analog iwl4965 mmc_core i2c_algo_bit pcmcia_core thermal container ac button fan battery e1000e iwl_legacy mac80211 snd_hda_intel cfg80211 snd_hda_codec pcmcia_rsrc processor rfkill snd_hwdep
> > [ 282.380932] Pid: 715, comm: btrfs-cleaner Not tainted 3.1.0-rc3-00203-gdbf2e46 #139
> > [ 282.380936] Call Trace:
> > [ 282.380947] [<ffffffff8103e7ba>] warn_slowpath_common+0x7a/0xb0
> > [ 282.380954] [<ffffffff8103e805>] warn_slowpath_null+0x15/0x20
> > [ 282.380960] [<ffffffff810eafbb>] iput+0x20b/0x210
> > [ 282.380967] [<ffffffff811b990b>] btrfs_iget+0x1eb/0x4a0
> > [ 282.380975] [<ffffffff811c3ce6>] btrfs_run_defrag_inodes+0x136/0x210
> > [ 282.380982] [<ffffffff811ad76f>] cleaner_kthread+0x17f/0x1a0
> > [ 282.380988] [<ffffffff81035b7d>] ? sub_preempt_count+0x9d/0xd0
> > [ 282.380994] [<ffffffff811ad5f0>] ? transaction_kthread+0x280/0x280
> > [ 282.381001] [<ffffffff8105b056>] kthread+0x96/0xa0
> > [ 282.381027] [<ffffffff81433914>] kernel_thread_helper+0x4/0x10
> > [ 282.381034] [<ffffffff8105afc0>] ? kthread_worker_fn+0x190/0x190
> > [ 282.381039] [<ffffffff81433910>] ? gs_change+0xb/0xb
> > [ 282.381044] ---[ end trace 40720e359a3c0fea ]---
>
> Konstantin's patch
>
> [PATCH] btrfs: fix warning in iput for bad-inode
>
> fixed the issue.
Actually, not quite. Busy spin popped up as described in:
http://www.spinics.net/lists/linux-btrfs/msg12156.html
--
Sergei
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-08-29 19:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-26 20:18 autodegrag: WARNING: at fs/inode.c:1315 iput+0x20b/0x210() Sergei Trofimovich
2011-08-27 14:15 ` Sergei Trofimovich
2011-08-28 8:49 ` Sergei Trofimovich
2011-08-29 19:19 ` Sergei Trofimovich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).