From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Mahoney Subject: [patch 18/65] btrfs: __unlock_for_delalloc should return void Date: Mon, 03 Oct 2011 23:22:48 -0400 Message-ID: <20111004032301.986483944@suse.com> References: <20111004032230.458853274@suse.com> Cc: Chris Mason To: BtrFS List Return-path: List-ID: __unlock_for_delalloc has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney --- fs/btrfs/extent_io.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -1196,9 +1196,9 @@ out: return found; } -static noinline int __unlock_for_delalloc(struct inode *inode, - struct page *locked_page, - u64 start, u64 end) +static noinline void __unlock_for_delalloc(struct inode *inode, + struct page *locked_page, + u64 start, u64 end) { int ret; struct page *pages[16]; @@ -1208,7 +1208,7 @@ static noinline int __unlock_for_delallo int i; if (index == locked_page->index && end_index == index) - return 0; + return; while (nr_pages > 0) { ret = find_get_pages_contig(inode->i_mapping, index, @@ -1223,7 +1223,6 @@ static noinline int __unlock_for_delallo index += ret; cond_resched(); } - return 0; } static noinline int lock_delalloc_pages(struct inode *inode,