From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Mahoney Subject: [patch 25/65] btrfs: btrfs_close_extra_devices should return void Date: Mon, 03 Oct 2011 23:22:55 -0400 Message-ID: <20111004032302.788495871@suse.com> References: <20111004032230.458853274@suse.com> Cc: Chris Mason To: BtrFS List Return-path: List-ID: btrfs_close_extra_devices has no error conditions and should return void. Its callers already ignore the error code anyway. Signed-off-by: Jeff Mahoney --- fs/btrfs/volumes.c | 3 +-- fs/btrfs/volumes.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -437,7 +437,7 @@ error: return ERR_PTR(-ENOMEM); } -int btrfs_close_extra_devices(struct btrfs_fs_devices *fs_devices) +void btrfs_close_extra_devices(struct btrfs_fs_devices *fs_devices) { struct btrfs_device *device, *next; @@ -470,7 +470,6 @@ again: } mutex_unlock(&uuid_mutex); - return 0; } static void __free_device(struct work_struct *work) --- a/fs/btrfs/volumes.h +++ b/fs/btrfs/volumes.h @@ -197,7 +197,7 @@ int btrfs_open_devices(struct btrfs_fs_d int btrfs_scan_one_device(const char *path, fmode_t flags, void *holder, struct btrfs_fs_devices **fs_devices_ret); int btrfs_close_devices(struct btrfs_fs_devices *fs_devices); -int btrfs_close_extra_devices(struct btrfs_fs_devices *fs_devices); +void btrfs_close_extra_devices(struct btrfs_fs_devices *fs_devices); int btrfs_add_device(struct btrfs_trans_handle *trans, struct btrfs_root *root, struct btrfs_device *device);