From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Mahoney Subject: [patch 52/65] btrfs: add_delayed_data_ref should return void Date: Mon, 03 Oct 2011 23:23:22 -0400 Message-ID: <20111004032305.875926415@suse.com> References: <20111004032230.458853274@suse.com> Cc: Chris Mason To: BtrFS List Return-path: List-ID: add_delayed_data_ref has no error conditions and should return void. Signed-off-by: Jeff Mahoney --- fs/btrfs/delayed-ref.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) --- a/fs/btrfs/delayed-ref.c +++ b/fs/btrfs/delayed-ref.c @@ -520,11 +520,11 @@ static noinline void add_delayed_tree_re /* * helper to insert a delayed data ref into the rbtree. */ -static noinline int add_delayed_data_ref(struct btrfs_trans_handle *trans, - struct btrfs_delayed_ref_node *ref, - u64 bytenr, u64 num_bytes, u64 parent, - u64 ref_root, u64 owner, u64 offset, - int action) +static noinline void add_delayed_data_ref(struct btrfs_trans_handle *trans, + struct btrfs_delayed_ref_node *ref, + u64 bytenr, u64 num_bytes, u64 parent, + u64 ref_root, u64 owner, u64 offset, + int action) { struct btrfs_delayed_ref_node *existing; struct btrfs_delayed_data_ref *full_ref; @@ -570,7 +570,6 @@ static noinline int add_delayed_data_ref delayed_refs->num_entries++; trans->delayed_ref_updates++; } - return 0; } /* @@ -628,7 +627,6 @@ int btrfs_add_delayed_data_ref(struct bt struct btrfs_delayed_data_ref *ref; struct btrfs_delayed_ref_head *head_ref; struct btrfs_delayed_ref_root *delayed_refs; - int ret; BUG_ON(extent_op && !extent_op->is_data); ref = kmalloc(sizeof(*ref), GFP_NOFS); @@ -652,9 +650,8 @@ int btrfs_add_delayed_data_ref(struct bt */ add_delayed_ref_head(trans, &head_ref->node, bytenr, num_bytes, action, 1); - ret = add_delayed_data_ref(trans, &ref->node, bytenr, num_bytes, - parent, ref_root, owner, offset, action); - BUG_ON(ret); + add_delayed_data_ref(trans, &ref->node, bytenr, num_bytes, parent, + ref_root, owner, offset, action); spin_unlock(&delayed_refs->lock); return 0; }