From: Chris Mason <chris.mason@oracle.com>
To: Josef Bacik <josef@redhat.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix our reservations for updating an inode when completing io V3
Date: Fri, 11 Nov 2011 07:52:57 -0500 [thread overview]
Message-ID: <20111111125257.GF4435@shiny> (raw)
In-Reply-To: <20111111122836.GX12759@twin.jikos.cz>
On Fri, Nov 11, 2011 at 01:28:36PM +0100, David Sterba wrote:
> On Thu, Nov 10, 2011 at 05:57:07PM -0500, Josef Bacik wrote:
> > --- a/fs/btrfs/ctree.h
> > +++ b/fs/btrfs/ctree.h
> > @@ -2699,8 +2699,8 @@ struct extent_map *btrfs_get_extent(struct inode *inode, struct page *page,
> > size_t pg_offset, u64 start, u64 end,
> > int create);
> > int btrfs_update_inode(struct btrfs_trans_handle *trans,
> > - struct btrfs_root *root,
> > - struct inode *inode);
> > + struct btrfs_root *root, struct inode *inode,
> > + int fallback);
>
> Can you please add a helper __btrfs_update_inode which takes the
> argument, leave btrfs_update_inode as is and add
> btrfs_update_inode_fallback for the '1' case?
>
> So you don't change every callsite of btrfs_update_inode and just those 4
> which need _fallback variant (the rest is 29, quite a lot).
I reworked this last night since I already have v2. See my for-linus
branch.
-chris
prev parent reply other threads:[~2011-11-11 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 22:57 [PATCH] Btrfs: fix our reservations for updating an inode when completing io V3 Josef Bacik
2011-11-11 12:28 ` David Sterba
2011-11-11 12:52 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111111125257.GF4435@shiny \
--to=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox