From: Josef Bacik <josef@redhat.com>
To: Christian Brunner <chb@muc.de>
Cc: Josef Bacik <josef@redhat.com>,
linux-btrfs@vger.kernel.org, sage@newdream.net
Subject: Re: [PATCH] Btrfs: protect orphan block rsv with spin_lock
Date: Mon, 5 Dec 2011 09:30:09 -0500 [thread overview]
Message-ID: <20111205143008.GA3046@localhost.localdomain> (raw)
In-Reply-To: <CAO47_-9=1Cai3Ux2CR-xc5DarRyQkEMWdFXk7=DKyU6OrDamOA@mail.gmail.com>
On Mon, Dec 05, 2011 at 12:50:39PM +0100, Christian Brunner wrote:
> 2011/12/2 Josef Bacik <josef@redhat.com>:
> > We've been seeing warnings coming out of the orphan commit stuff fo=
rever from
> > ceph. =A0Turns out it's because we're racing with checking if the o=
rphan block
> > reserve is set, because we clear it outside of the spin_lock. =A0So=
leave the
> > normal fastpath checks where they are, but take the spin_lock and _=
recheck_ to
> > make sure we haven't had an orphan block rsv added in the meantime.=
=A0Then clear
> > the root's orphan block rsv and release the lock. =A0With this patc=
h a user said
> > the warnings went away and they usually showed up pretty soon after=
he started
> > ceph. =A0Thanks,
>=20
> *sigh* - As soon as I turned my back to the serve console it also
> happened again on one of our nodes. That was 25 hours after I started
> the system. Usually I see these warnings a few minutes after the
> start, but the have been cases in the past where it took longer. So
> I'm not sure if the improvement is due to the patch.
>=20
> Josef: I was still running the patch you sent me, but there was no
> message from the printk's you added.
>=20
:( ok I'll try again. Thanks,
Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-12-05 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 20:44 [PATCH] Btrfs: protect orphan block rsv with spin_lock Josef Bacik
2011-12-03 19:53 ` Stefan Kleijkers
2011-12-05 11:50 ` Christian Brunner
2011-12-05 14:30 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205143008.GA3046@localhost.localdomain \
--to=josef@redhat.com \
--cc=chb@muc.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox