From: Chris Mason <chris.mason@oracle.com>
To: Liu Bo <liubo2009@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: hold enough space for global_rsv
Date: Fri, 27 Jan 2012 10:25:29 -0500 [thread overview]
Message-ID: <20120127152529.GA991@shiny> (raw)
In-Reply-To: <1326793919-2712-1-git-send-email-liubo2009@cn.fujitsu.com>
On Tue, Jan 17, 2012 at 05:51:59PM +0800, Liu Bo wrote:
> I've kept hitting enospc warnings of global_rsv while running defragment on
> files:
> btrfs: block rsv returned -28
> WARNING: at fs/btrfs/extent-tree.c:5984 btrfs_alloc_free_block+0x333/0x340 [btrfs]()
> ...
>
> I used a fio jobs to create a file with lots of fragments:
> $ filefrag /mnt/btrfs/foobar
> /mnt/btrfs/foobar: 66964 extents found
>
> and then "btrfs fi defrag /mnt/btrfs/foobar && sync" would pop the warnings.
>
> I found that the global_rsv size is just not enough for defragment, and didn't
> find any space leak in using global_rsv, so double it and go ahead.
I haven't pulled this one in yet, mostly because I think we need to take
a step back and look harder at the numbers.
-chris
next prev parent reply other threads:[~2012-01-27 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 9:51 [PATCH] Btrfs: hold enough space for global_rsv Liu Bo
2012-01-27 15:25 ` Chris Mason [this message]
2012-02-27 13:29 ` Johannes Hirte
2012-02-28 2:06 ` Liu Bo
2012-03-06 13:50 ` Johannes Hirte
2012-03-08 19:22 ` Johannes Hirte
2012-03-09 1:28 ` Liu Bo
2012-03-10 20:12 ` Johannes Hirte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120127152529.GA991@shiny \
--to=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).