From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Nikos Voutsinas <nvoutsin@noc.edunet.gr>,
dave@jikos.cz, linux-btrfs@vger.kernel.org, kreijack@gmail.com,
chris.mason@oracle.com
Subject: Re: subvolume info in /proc/mounts
Date: Mon, 6 Feb 2012 13:52:15 +0000 [thread overview]
Message-ID: <20120206135215.GE23916@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20120206121823.GA24922@infradead.org>
On Mon, Feb 06, 2012 at 07:18:24AM -0500, Christoph Hellwig wrote:
> On Mon, Feb 06, 2012 at 12:53:21PM +0100, David Sterba wrote:
> > On Sun, Feb 05, 2012 at 12:30:42PM +0200, Nikos Voutsinas wrote:
> > > It's quite old, but what was this about;
> > >
> > > http://thread.gmane.org/gmane.comp.file-systems.btrfs/4487
> >
> > Thanks, the patch looks ok and works as expected.
> >
> > Goffredo, do you want to resend it? (The lock around the mnt_root is not
> > necessary.) I think it's a -rc material, more people came to ask about
> > this on irc channel lately, we don't need to wait a full release cycle
> > to merge this fix.
>
> No, it doesn't look good. Please do not introduce anything touching
> non-superblock fields in ->show_options, thanks.
Umm... seq_dentry() on root dentry (which is what's getting passed to
->show_options() now) would be OK; this kind of playing with ->d_name
is not.
next prev parent reply other threads:[~2012-02-06 13:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-04 18:40 subvolume info in /proc/mounts Nikos Voutsinas
2012-02-04 21:44 ` David Sterba
2012-02-05 10:30 ` Nikos Voutsinas
2012-02-05 23:38 ` Fajar A. Nugraha
2012-02-06 11:53 ` David Sterba
2012-02-06 12:18 ` Christoph Hellwig
2012-02-06 13:52 ` Al Viro [this message]
2012-02-09 13:44 ` David Sterba
2012-02-21 14:31 ` David Sterba
2012-02-07 19:05 ` Goffredo Baroncelli
2012-02-06 9:52 ` Karel Zak
-- strict thread matches above, loose matches on Subject: below --
2012-02-10 22:42 Nikos Voutsinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206135215.GE23916@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=chris.mason@oracle.com \
--cc=dave@jikos.cz \
--cc=hch@infradead.org \
--cc=kreijack@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nvoutsin@noc.edunet.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).