From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: subvolume info in /proc/mounts
Date: Mon, 6 Feb 2012 13:52:15 +0000
Message-ID: <20120206135215.GE23916@ZenIV.linux.org.uk>
References: <13975aa6fbfab9c845a2582c043aa938.squirrel@webmail01.edunet.gr>
 <20120204214430.GA15350@twin.jikos.cz>
 <2ed5fe028fdcfd3d53cf217e13b827d9.squirrel@webmail01.edunet.gr>
 <20120206115321.GB15350@twin.jikos.cz>
 <20120206121823.GA24922@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Nikos Voutsinas <nvoutsin@noc.edunet.gr>, dave@jikos.cz,
	linux-btrfs@vger.kernel.org, kreijack@gmail.com,
	chris.mason@oracle.com
To: Christoph Hellwig <hch@infradead.org>
Return-path: <linux-btrfs-owner@vger.kernel.org>
In-Reply-To: <20120206121823.GA24922@infradead.org>
List-ID: <linux-btrfs.vger.kernel.org>

On Mon, Feb 06, 2012 at 07:18:24AM -0500, Christoph Hellwig wrote:
> On Mon, Feb 06, 2012 at 12:53:21PM +0100, David Sterba wrote:
> > On Sun, Feb 05, 2012 at 12:30:42PM +0200, Nikos Voutsinas wrote:
> > > It's quite old, but what was this about;
> > > 
> > > http://thread.gmane.org/gmane.comp.file-systems.btrfs/4487
> > 
> > Thanks, the patch looks ok and works as expected.
> > 
> > Goffredo, do you want to resend it? (The lock around the mnt_root is not
> > necessary.) I think it's a -rc material, more people came to ask about
> > this on irc channel lately, we don't need to wait a full release cycle
> > to merge this fix.
> 
> No, it doesn't look good.  Please do not introduce anything touching
> non-superblock fields in ->show_options, thanks.

Umm...  seq_dentry() on root dentry (which is what's getting passed to
->show_options() now) would be OK; this kind of playing with ->d_name
is not.