From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Brown <davidb@davidb.org>
Cc: Chris Mason <chris.mason@oracle.com>,
linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Btrfs: silence a compiler warning
Date: Wed, 22 Feb 2012 19:37:21 +0300 [thread overview]
Message-ID: <20120222163721.GB4096@mwanda> (raw)
In-Reply-To: <20120222162926.GA25392@davidb.org>
[-- Attachment #1: Type: text/plain, Size: 978 bytes --]
On Wed, Feb 22, 2012 at 08:29:26AM -0800, David Brown wrote:
> On Wed, Feb 22, 2012 at 10:30:55AM +0300, Dan Carpenter wrote:
> >Gcc warns that "ret" can be used uninitialized. It can't actually be
> >used uninitialized because btrfs_num_copies() always returns 1 or more.
> >
> >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> >diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c
> >index 064b29b..c053e90 100644
> >--- a/fs/btrfs/check-integrity.c
> >+++ b/fs/btrfs/check-integrity.c
> >@@ -643,7 +643,7 @@ static struct btrfsic_dev_state *btrfsic_dev_state_hashtable_lookup(
> >static int btrfsic_process_superblock(struct btrfsic_state *state,
> > struct btrfs_fs_devices *fs_devices)
> >{
> >- int ret;
> >+ int ret = 0;
>
> Does
>
> int uninitialized_var(ret);
>
> work? The assignment to zero actually generates additional
> (unnecessary) code.
Sure. I can resend it.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-22 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 7:30 [patch] Btrfs: silence a compiler warning Dan Carpenter
2012-02-22 16:29 ` David Brown
2012-02-22 16:37 ` Dan Carpenter [this message]
2012-02-22 19:41 ` [patch v2] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222163721.GB4096@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chris.mason@oracle.com \
--cc=davidb@davidb.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).