linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hugo Mills <hugo@carfax.org.uk>
To: Alex <alex@bpmit.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: SELinux inode size gotcha in btrfs.
Date: Tue, 28 Feb 2012 11:37:05 +0000	[thread overview]
Message-ID: <20120228113705.GD4481@carfax.org.uk> (raw)
In-Reply-To: <loom.20120228T122833-822@post.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1788 bytes --]

On Tue, Feb 28, 2012 at 11:30:26AM +0000, Alex wrote:
> David Sterba <dave <at> jikos.cz> writes:
> 
> > 
> > That's right. Inode represented as btrfs_inode_item does not contain any
> > xattr fields, they're stored independently as a btrfs_dir_item of type
> > BTRFS_FT_XATTR . Due to the way the b-tree keys are built, the xattr
> > item key should be stored near the inode item key, that's for the tree
> > search side. The xattr data are always stored inline in the b-tree leaf.
> > 
> 
> 
> Thank you David and Hugo,
> 
> My bad on three counts:
> 1) My courtesy close seems to have gone missing.
>  Sorry and thank you for replying.
> 2) I, perhaps, should have pointed to
> https://wiki.debian.org/SELinux/Setup#Prerequisites
> _.28kernel_and_filesystems.29
> which gives a better explanation.

   Aaah, OK, that makes sense now. So: we don't have the issue over
xattr sizes at all. The main issue would then seem to be over
atomicity of writing xattrs -- I don't know what the APIs for this
look like, or whether we've implemented them, so I can't comment any
further on btrfs's suitability I'm afraid.

> 3) Made it clear that I wasn't attacking
>  XFS, It's my fs of (non /boot) choice
> for some years now; I'm exploring SELinux
>  (after the recent Linux conf au 2012
> talk) and know I have used inode size defaults
>  for my xfs init back in the day!

   I certainly didn't read it as such.

   Hugo.

-- 
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
  PGP key: 515C238D from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
   --- In the future, terrorists won't be carrying their ID cards. ---   
                   They'll be carrying yours. -- Henry                   
                         Porter,  Suspect Nation                         

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

      reply	other threads:[~2012-02-28 11:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-27 22:18 SELinux inode size gotcha in btrfs Alex
2012-02-27 23:09 ` Hugo Mills
2012-02-27 23:17 ` David Sterba
2012-02-28 11:30   ` Alex
2012-02-28 11:37     ` Hugo Mills [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120228113705.GD4481@carfax.org.uk \
    --to=hugo@carfax.org.uk \
    --cc=alex@bpmit.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).