From: Andrea Gelmini <andrea.gelmini@gmail.com>
To: Liu Bo <liubo2009@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] Btrfs: fix deadlock during allocating chunks
Date: Thu, 15 Mar 2012 16:08:03 +0100 [thread overview]
Message-ID: <20120315150737.GE6474@pambianco.com> (raw)
In-Reply-To: <1331723829-25226-1-git-send-email-liubo2009@cn.fujitsu.com>
On Wed, Mar 14, 2012 at 07:17:09PM +0800, Liu Bo wrote:
> This deadlock comes from xfstests 251.
>
> We'll hold the chunk_mutex throughout the whole of a chunk allocation.
> But if we find that we've used up system chunk space, we need to allocate a
> new system chunk, but this will lead to a recursion of chunk allocation and end
> up with a deadlock on chunk_mutex.
> So instead we need to allocate the system chunk first if we find we're in ENOSPC.
I'm using this patch without problem since you published it (compressed
/home with hourly snapshot delete/creation).
Thanks a lot for your work,
Andrea
prev parent reply other threads:[~2012-03-15 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 11:17 [PATCH v2] Btrfs: fix deadlock during allocating chunks Liu Bo
2012-03-15 15:08 ` Andrea Gelmini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120315150737.GE6474@pambianco.com \
--to=andrea.gelmini@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).