linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Dave Jones <davej@redhat.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-btrfs@vger.kernel.org
Subject: Re: btrfs io errors on 3.4rc1
Date: Mon, 2 Apr 2012 19:50:50 -0400	[thread overview]
Message-ID: <20120402235021.GA20070@shiny.msi.event> (raw)
In-Reply-To: <20120402225131.GB16907@redhat.com>

On Mon, Apr 02, 2012 at 06:51:31PM -0400, Dave Jones wrote:
> On Mon, Apr 02, 2012 at 06:39:19PM -0400, Chris Mason wrote:
>  > On Mon, Apr 02, 2012 at 06:33:50PM -0400, Dave Jones wrote:
>  > > On Mon, Apr 02, 2012 at 06:28:02PM -0400, Chris Mason wrote:
>  > >  
>  > >  > > x86-64.
>  > >  > > 
>  > >  > > dmesg below.  (ignore the rpc oops, reported elsewhere, it's unrelated)
>  > >  > 
>  > >  > Well, there really are no btrfs messages in there at all.  Do you have
>  > >  > free space for a clean copy of the btrfs partition?  Trying to figure
>  > >  > out if you have a stale corruption (on two boxes seems really unlikely).
>  > >  > I definitely can't reproduce it here.
>  > > 
>  > > Don't really have any free space for it (It's the / partition on both)
>  > > 
>  > > Is there a wip btrfs.fsck yet ? One of the machines is just a scratch testbox,
>  > > so I'm happy to run it even if it'll potentially make things worse.
>  > 
>  > The current btrfsck repair mode will fix problems in the extent
>  > allocation tree, but that probably isn't what you're seeing.  I'd just
>  > run it read only and see if it finds any problems.
>  > 
>  > (You'll need the FS completely unmounted though).
> 
> I'll start a bisect later to see if I can narrow it down at least.

Ok, a directed bisect of the major suspects.  Josef changed the extent
buffer eio code in this commit (jump to the commit before it):

commit ea466794084f55d8fcc100711cf17923bf57e962
Author: Josef Bacik <josef@redhat.com>
Date:   Mon Mar 26 21:57:36 2012 -0400

    Btrfs: deal with read errors on extent buffers differently

You can jump to the commit before my big blocks change:

commit 727011e07cbdf87772fcc1999cccd15cc915eb62
Author: Chris Mason <chris.mason@oracle.com>
Date:   Fri Aug 6 13:21:20 2010 -0400

    Btrfs: allow metadata blocks larger than the page size

The SUSE code would be my other suspect.  It came from this commit:

commit 1d4284bd6e8d7dd1d5521a6747bdb6dc1caf0225
Merge: b5d67f6 65139ed
Author: Chris Mason <chris.mason@oracle.com>
Date:   Wed Mar 28 20:31:37 2012 -0400

    Merge branch 'error-handling' into for-linus

commit 65139ed99234d8505948cdb7a835452eb5c191f9
Author: David Sterba <dsterba@suse.cz>
Date:   Fri Feb 17 12:26:09 2012 +0100

    btrfs: disallow unequal data/metadata blocksize for mixed block
groups

So if you git reset --hard b5d67f6, you'll get rid of the suse code.

Thanks Dave!

-chris

  reply	other threads:[~2012-04-02 23:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 18:02 btrfs io errors on 3.4rc1 Dave Jones
2012-04-02 19:48 ` Chris Mason
2012-04-02 21:16   ` Dave Jones
2012-04-02 21:26     ` Chris Mason
2012-04-02 21:40       ` Dave Jones
2012-04-02 22:28         ` Chris Mason
2012-04-02 22:33           ` Dave Jones
2012-04-02 22:39             ` Chris Mason
2012-04-02 22:51               ` Dave Jones
2012-04-02 23:50                 ` Chris Mason [this message]
2012-04-03  1:47                   ` Dave Jones
2012-04-03 14:26                     ` David Sterba
2012-04-03 16:20                       ` Dave Jones
2012-04-03 16:33                         ` David Sterba
2012-04-03 16:50                           ` Dave Jones
2012-04-03 17:07                             ` Dave Jones
2012-04-03 17:16                               ` Dave Jones
2012-04-03 17:24                                 ` David Sterba
2012-04-03 19:35                                 ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120402235021.GA20070@shiny.msi.event \
    --to=chris.mason@oracle.com \
    --cc=davej@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).