From: Josef Bacik <josef@redhat.com>
To: "Kasatkin, Dmitry" <dmitry.kasatkin@intel.com>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
Josef Bacik <josef@redhat.com>,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
linux-btrfs@vger.kernel.org, hch@infradead.org
Subject: Re: [RFC] [PATCH 2/2] Btrfs: move over to use ->update_time
Date: Wed, 4 Apr 2012 14:16:22 -0400 [thread overview]
Message-ID: <20120404181622.GC2097@localhost.localdomain> (raw)
In-Reply-To: <CALLzPKYvPqi=9dboZDh4Gm0Poouoa2ZY7K3hbhS9bmkiK6nFAQ@mail.gmail.com>
On Wed, Apr 04, 2012 at 09:12:57PM +0300, Kasatkin, Dmitry wrote:
> On Wed, Apr 4, 2012 at 8:47 PM, Mimi Zohar <zohar@linux.vnet.ibm.com>=
wrote:
> > On Wed, 2012-04-04 at 13:43 -0400, Josef Bacik wrote:
> >> On Wed, Apr 04, 2012 at 08:24:19PM +0300, Kasatkin, Dmitry wrote:
> >> > Hello,
> >> >
> >> > Mimi and I working on IMA/EVM (security/integrity) and it uses
> >> > i_version for checking if file content has been changed.
> >> > extX file systems support i_version updates with mounting file s=
ystem
> >> > with "iversion" option or via kernel command line parameter
> >> > "i_version"
> >> >
> >> > It seems iversion option is not recognized when mounting btrfs.
> >> > I see this patchset deals with i_version update as well..
> >> > Can you please give an advice how to use i_version with btrfs?
> >> >
> >>
> >> Oh good somebody uses this? =A0We actually have a ->sequence thing=
we use for
> >> this, the grand idea was to make it smarter about telling nfs when=
something
> >> changed, but if you guys use i_version we could probably get rid o=
f our in-core
> >> sequence and use the normal inodes i_version and then just store i=
t in our
> >> sequence field on disk. =A0I'll do it without a mount option tho s=
o it just works,
> >> does that sound good to you? =A0Thanks,
>=20
> Hello,
>=20
> Thank you for the answer...
> But can you a bit clarify...
>=20
> Looking to file_update_time() I see that it does:
>=20
> if (IS_I_VERSION(inode))
> sync_it |=3D S_VERSION;
>=20
> Basically it should be (inode->i_sb->s_flags & MS_I_VERSION)
>=20
> use of i_version is controlled by iversion mount flag.
> for ext4 I see in parse_options():
>=20
> case Opt_i_version:
> set_opt(sb, I_VERSION);
> sb->s_flags |=3D MS_I_VERSION;
> break;
>=20
>=20
> But who sets MS_I_VERSION in s_flags on btrfs?
>=20
Nobody yet, I'm going to send a patch shortly that will support this. =
Thanks,
Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-04-04 18:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-26 14:10 [RFC] [PATCH 1/2] fs: introduce inode operation ->update_time Josef Bacik
2012-03-26 14:10 ` [RFC] [PATCH 2/2] Btrfs: move over to use ->update_time Josef Bacik
2012-04-04 17:24 ` Kasatkin, Dmitry
2012-04-04 17:43 ` Josef Bacik
2012-04-04 17:47 ` Mimi Zohar
2012-04-04 18:12 ` Kasatkin, Dmitry
2012-04-04 18:16 ` Josef Bacik [this message]
2012-04-04 18:21 ` Kasatkin, Dmitry
2012-04-09 15:16 ` J. Bruce Fields
2012-04-10 7:48 ` David Sterba
2012-04-12 11:09 ` Kasatkin, Dmitry
2012-04-12 11:32 ` David Sterba
2012-04-12 11:43 ` Kasatkin, Dmitry
2012-05-11 6:06 ` Kasatkin, Dmitry
2012-05-11 18:34 ` Josef Bacik
2012-04-30 15:21 ` [RFC] [PATCH 1/2] fs: introduce inode operation ->update_time Christoph Hellwig
2012-04-30 17:12 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404181622.GC2097@localhost.localdomain \
--to=josef@redhat.com \
--cc=dmitry.kasatkin@intel.com \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).