From: Ilya Dryomov <idryomov@gmail.com>
To: Bobby Powers <bobbypowers@gmail.com>
Cc: linux-btrfs@vger.kernel.org, Chris Mason <chris.mason@oracle.com>,
Andi Kleen <ak@linux.intel.com>, Jeff Mahoney <jeffm@suse.de>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Btrfs, lockdep: get_restripe_target: use lockdep in BUG_ON
Date: Thu, 5 Apr 2012 19:51:48 +0300 [thread overview]
Message-ID: <20120405165148.GA2595@zambezi.lan> (raw)
In-Reply-To: <CAArOQ2Vc35VnbTCAZigTGZ3pL-f8mAtA9Ugpdjo5S=M7Ujpeiw@mail.gmail.com>
On Thu, Apr 05, 2012 at 12:23:01PM -0400, Bobby Powers wrote:
> On Wed, Apr 4, 2012 at 10:04 PM, Bobby Powers <bobbypowers@gmail.com>=
wrote:
> > spin_is_locked always returns 0 on non-SMP systems, which causes bt=
rfs
> > to fail the mount. =C2=A0There is documentation pending as to why c=
hecking
>=20
> I guess I should be explicit in stating that this is a regression, so
> this patch or something else that addresses it should be pulled into
> 3.4.
Yes, this is a regression and spin_is_locked() definitely has to go. I
don't have a strong opinion on this assert, if there are objections to
v2 I'm OK with ripping that BUG_ON entirely and replacing it with a
comment (this function and its callers are WIP).
Thanks,
Ilya
next prev parent reply other threads:[~2012-04-05 16:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 20:19 [PATCH] Btrfs: remove BUG_ON from get_restripe_target Bobby Powers
2012-04-05 0:46 ` Jeff Mahoney
2012-04-05 1:19 ` Bobby Powers
2012-04-05 1:48 ` Bobby Powers
2012-04-05 2:04 ` [PATCH v2] Btrfs, lockdep: get_restripe_target: use lockdep in BUG_ON Bobby Powers
2012-04-05 16:23 ` Bobby Powers
2012-04-05 16:51 ` Ilya Dryomov [this message]
2012-04-06 17:20 ` Mitch Harder
2012-04-06 20:05 ` Ilya Dryomov
2012-04-07 1:06 ` Bobby Powers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120405165148.GA2595@zambezi.lan \
--to=idryomov@gmail.com \
--cc=ak@linux.intel.com \
--cc=bobbypowers@gmail.com \
--cc=chris.mason@oracle.com \
--cc=jeffm@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).