linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <josef@redhat.com>
To: Jim Schutt <jaschut@sandia.gov>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: kernel BUG at fs/btrfs/extent_io.c:3982!
Date: Wed, 11 Apr 2012 15:09:27 -0400	[thread overview]
Message-ID: <20120411190926.GE2506@localhost.localdomain> (raw)
In-Reply-To: <4F848C62.6030100@sandia.gov>

On Tue, Apr 10, 2012 at 01:39:14PM -0600, Jim Schutt wrote:
> Hi,
> 
> I hit this BUG today.
> 
> I'm running 3.3.1 merged with the ceph and btrfs bits for 3.4,
> i.e. 3.3.1 +
>   commit bc3f116fec194 "Btrfs: update the checks for mixed block groups with big metadata blocks"
>   commit c666601a935b9 "rbd: move snap_rwsem to the device, rename to header_rwsem"
> 
> The btrfs filesystem in question is backing a Ceph OSD under
> a heavy write load.
> 
> Here's the bug:
> 

Can you give this a whirl and let me know how it goes?  If I'm right you should
see a warning pop up in your messages.  Thanks,

Josef

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 26fbe1c..0d81fd4 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -55,6 +55,7 @@ struct extent_page_data {
 };
 
 static noinline void flush_write_bio(void *data);
+static void check_buffer_tree_ref(struct extent_buffer *eb);
 static inline struct btrfs_fs_info *
 tree_fs_info(struct extent_io_tree *tree)
 {
@@ -3264,6 +3265,12 @@ retry:
 				continue;
 			}
 
+			if (unlikely(!test_bit(EXTENT_BUFFER_TREE_REF,
+					       &eb->bflags))) {
+				WARN_ON(1);
+				check_buffer_tree_ref(eb);
+			}
+
 			prev_eb = eb;
 			ret = lock_extent_buffer_for_io(eb, fs_info, &epd);
 			if (!ret) {

  parent reply	other threads:[~2012-04-11 19:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-10 19:39 kernel BUG at fs/btrfs/extent_io.c:3982! Jim Schutt
2012-04-10 20:24 ` Chris Mason
2012-04-10 20:32   ` Jim Schutt
2012-04-11 19:09 ` Josef Bacik [this message]
2012-04-11 20:24   ` Jim Schutt
2012-04-11 20:28     ` Josef Bacik
2012-04-11 21:39       ` Jim Schutt
2012-04-12  0:29         ` Chris Mason
2012-05-01 16:00     ` Josef Bacik
2012-05-01 16:41       ` Jim Schutt
2012-05-03 14:43         ` Jim Schutt
2012-05-03 14:53           ` Josef Bacik
2012-05-03 15:46             ` [EXTERNAL] " Jim Schutt
2012-05-03 15:53               ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120411190926.GE2506@localhost.localdomain \
    --to=josef@redhat.com \
    --cc=jaschut@sandia.gov \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).