From: Mark Fasheh <mfasheh@suse.de>
To: Chris Mason <chris.mason@oracle.com>,
Jan Schmidt <list.btrfs@jan-o-sch.net>,
Jeff Mahoney <jeffm@suse.de>,
linux-btrfs@vger.kernel.org, Josef Bacik <josef@redhat.com>
Subject: Re: [PATCH 0/3] btrfs: extended inode refs
Date: Thu, 12 Apr 2012 09:19:03 -0700 [thread overview]
Message-ID: <20120412161903.GP17950@wotan.suse.de> (raw)
In-Reply-To: <20120412161113.GM29506@shiny>
On Thu, Apr 12, 2012 at 12:11:13PM -0400, Chris Mason wrote:
> On Wed, Apr 11, 2012 at 03:11:46PM +0200, Jan Schmidt wrote:
> > Hi Jeff,
> > >
> > >> An alternative solution to dealing with collisions could be to
> > >> emulate the dir-item insertion code - specifically something like
> > >> insert_with_overflow() which will stuff multiple items under one
> > >> key. I tend to prefer the idea of
> > >
> > > I vote for this option.
>
> [ Big patch series, thanks Mark! ]
>
> I prefer the insert_with_overflow because it makes the deletion case
> less complex. If we handle collisions with bits in the offset, we have
> to search around in the tree to find the key that was actually used to
> insert the item.
>
> The insert_with_overflow code uses just one key, at the cost of having
> to search around inside the item.
Yeah this actually turns out to be a bit easier to code as well. I'm taking
this approach.
--Mark
--
Mark Fasheh
next prev parent reply other threads:[~2012-04-12 16:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 20:09 [PATCH 0/3] btrfs: extended inode refs Mark Fasheh
2012-04-05 20:09 ` [PATCH 1/3] " Mark Fasheh
2012-04-12 13:08 ` Jan Schmidt
2012-04-24 22:23 ` Mark Fasheh
2012-04-25 10:19 ` Jan Schmidt
2012-04-05 20:09 ` [PATCH 2/3] " Mark Fasheh
2012-04-12 13:08 ` Jan Schmidt
2012-05-03 23:12 ` Mark Fasheh
2012-05-04 11:39 ` David Sterba
2012-04-12 15:53 ` Jan Schmidt
2012-05-01 18:39 ` Mark Fasheh
2012-04-05 20:09 ` [PATCH 3/3] " Mark Fasheh
2012-04-12 17:59 ` Jan Schmidt
2012-04-12 18:38 ` Jan Schmidt
2012-05-08 22:57 ` Mark Fasheh
2012-05-09 17:02 ` Chris Mason
2012-05-10 8:23 ` Jan Schmidt
2012-05-10 13:35 ` Chris Mason
2012-04-05 21:13 ` [PATCH 0/3] " Jeff Mahoney
2012-04-11 13:11 ` Jan Schmidt
2012-04-11 13:29 ` Jan Schmidt
2012-04-12 16:11 ` Chris Mason
2012-04-12 16:19 ` Mark Fasheh [this message]
2012-04-06 1:24 ` Liu Bo
2012-04-06 2:12 ` Liu Bo
-- strict thread matches above, loose matches on Subject: below --
2012-05-21 21:46 Mark Fasheh
2012-08-08 18:55 Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120412161903.GP17950@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=chris.mason@oracle.com \
--cc=jeffm@suse.de \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).