From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sergey V." Subject: Re: [PATCH v2] btrfs: fix early abort in 'remount' Date: Mon, 16 Apr 2012 15:52:11 +0400 Message-ID: <201204161552.11922.sftp.mtuci@gmail.com> References: <4F8B7214.5010702@cn.fujitsu.com> <1334547877-13726-1-git-send-email-slyich@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Cc: linux-btrfs@vger.kernel.org, Liu Bo , Sergei Trofimovich , Jeff Mahoney , Chris Mason , Josef Bacik To: Sergei Trofimovich Return-path: In-Reply-To: <1334547877-13726-1-git-send-email-slyich@gmail.com> List-ID: On Monday 16 of April 2012 07:44:37 Sergei Trofimovich wrote: > From: Sergei Trofimovich > > Cc: Jeff Mahoney > Cc: Chris Mason > Cc: Josef Bacik > Signed-off-by: Sergei Trofimovich > --- > fs/btrfs/super.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c > index 8d5d380..2f28fc0 100644 > --- a/fs/btrfs/super.c > +++ b/fs/btrfs/super.c > @@ -1148,13 +1148,15 @@ static int btrfs_remount(struct super_block *sb, int *flags, char *data) > if (ret) > goto restore; > } else { > - if (fs_info->fs_devices->rw_devices == 0) > + if (fs_info->fs_devices->rw_devices == 0) { > ret = -EACCES; > goto restore; > + } > > - if (btrfs_super_log_root(fs_info->super_copy) != 0) > + if (btrfs_super_log_root(fs_info->super_copy) != 0) { > ret = -EINVAL; > goto restore; > + } > > ret = btrfs_cleanup_fs_roots(fs_info); > if (ret) > -- Patch is correct Reviewed-by: Sergey V. Thanks.