From: Josef Bacik <josef@redhat.com>
To: Chris Mason <chris.mason@oracle.com>,
Arne Jansen <sensille@gmx.net>, Josef Bacik <josef@redhat.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: don't return EINTR
Date: Tue, 17 Apr 2012 14:22:20 -0400 [thread overview]
Message-ID: <20120417182219.GA4143@localhost.localdomain> (raw)
In-Reply-To: <20120417152401.GL28915@shiny>
On Tue, Apr 17, 2012 at 11:24:01AM -0400, Chris Mason wrote:
> On Tue, Apr 17, 2012 at 04:15:32PM +0200, Arne Jansen wrote:
> > On 14.04.2012 14:56, Arne Jansen wrote:
> > > It is basically a good thing if we are interruptible when waiting for
> > > free space, but the generality in which it is implemented currently
> > > leads to system calls being interruptible that are not documented this
> > > way. For example git can't handle interrupted unlink(), leading to
> > > corrupt repos under space pressure.
> >
> > Is this patch a candidate for the next rc?
>
> The EINTR came from Josef. We do want to be able to break out of long
> flushes, but I want to check with him to see if there was a specific bug
> this was solving?
Sorry I was -ENOINTERNET, no the only thing I was fixing was being able to break
out of long flushes. Maybe instead of using the big hammer here we just make
unlink ignore EINTR and try again, or maybe pass down a flag saying I can't be
interrupted? Thanks,
Josef
next prev parent reply other threads:[~2012-04-17 18:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 12:56 [PATCH] btrfs: don't return EINTR Arne Jansen
2012-04-17 14:15 ` Arne Jansen
2012-04-17 15:24 ` Chris Mason
2012-04-17 18:22 ` Josef Bacik [this message]
2012-04-17 18:56 ` Arne Jansen
2012-04-17 19:14 ` Josef Bacik
2012-04-17 19:34 ` Chris Mason
2012-04-17 19:36 ` Josef Bacik
2012-04-17 19:38 ` Chris Mason
2012-04-17 19:43 ` Arne Jansen
2012-04-17 23:39 ` Chris Samuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417182219.GA4143@localhost.localdomain \
--to=josef@redhat.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sensille@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).