Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Josef Bacik <josef@redhat.com>
Cc: Arne Jansen <sensille@gmx.net>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: don't return EINTR
Date: Tue, 17 Apr 2012 15:38:43 -0400	[thread overview]
Message-ID: <20120417193843.GV28915@shiny> (raw)
In-Reply-To: <20120417193619.GC4143@localhost.localdomain>

On Tue, Apr 17, 2012 at 03:36:20PM -0400, Josef Bacik wrote:
> > > Well then passing a flag down that says we can't interrupt I guess is what we're
> > > going to have to do and just wait uninterruptible.  I think our best bet is to
> > > just fix them as they come up, I thought all system calls could return EINTR but
> > > apparently I was wrong :).  Thanks,
> > 
> > I'd guess that EINTR is unexpected most of the time.  Including in reads
> > and writes.  The real question is how long we might end up waiting?
> > 
> 
> EINTR is valid for both reads and writes.  This was put into place when I would
> run tests and get tired of waiting for them so I'd ctrl+c and it wouldn't stop
> even though it's something that's completely stoppable.  So I'd like to leave it
> in there so at the very least I can still ctrl+c when I accidently run something
> I don't want to run ;).  Thanks,

Ok. lets just teach git how to eintr.


-chris

  reply	other threads:[~2012-04-17 19:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-14 12:56 [PATCH] btrfs: don't return EINTR Arne Jansen
2012-04-17 14:15 ` Arne Jansen
2012-04-17 15:24   ` Chris Mason
2012-04-17 18:22     ` Josef Bacik
2012-04-17 18:56       ` Arne Jansen
2012-04-17 19:14         ` Josef Bacik
2012-04-17 19:34           ` Chris Mason
2012-04-17 19:36             ` Josef Bacik
2012-04-17 19:38               ` Chris Mason [this message]
2012-04-17 19:43                 ` Arne Jansen
2012-04-17 23:39                   ` Chris Samuel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120417193843.GV28915@shiny \
    --to=chris.mason@oracle.com \
    --cc=josef@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sensille@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox