From: Josef Bacik <josef@redhat.com>
To: Daniel J Blueman <daniel@quora.org>
Cc: Josef Bacik <josef@redhat.com>,
Chris Mason <chris.mason@oracle.com>,
Linux BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: block_rsv_check EAGAIN vs ENOSPC...
Date: Tue, 24 Apr 2012 11:54:02 -0400 [thread overview]
Message-ID: <20120424155402.GF3326@localhost.localdomain> (raw)
In-Reply-To: <CAMVG2stv_CbF=-A=yS40_Q6N5+_fpc2SSJxL3Rga0LQXpc8MSA@mail.gmail.com>
On Tue, Apr 24, 2012 at 11:50:24PM +0800, Daniel J Blueman wrote:
> With 3.4-rc4 under certain workloads, I see btrfs_block_rsv_check
> return -ENOSPC.
>
> Since btrfs_block_rsv_check can only return -ENOSPC or 0,
> relocation.c:3816 checks for -EAGAIN, which is either redundant or
> should be -ENOSPC, which I initially suspected.
>
> Let me know which the behaviour should be and I'll get a patch tested and sent.
>
Yup you are right, thanks,
Josef
prev parent reply other threads:[~2012-04-24 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-24 15:50 block_rsv_check EAGAIN vs ENOSPC Daniel J Blueman
2012-04-24 15:54 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120424155402.GF3326@localhost.localdomain \
--to=josef@redhat.com \
--cc=chris.mason@oracle.com \
--cc=daniel@quora.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).