* block_rsv_check EAGAIN vs ENOSPC...
@ 2012-04-24 15:50 Daniel J Blueman
2012-04-24 15:54 ` Josef Bacik
0 siblings, 1 reply; 2+ messages in thread
From: Daniel J Blueman @ 2012-04-24 15:50 UTC (permalink / raw)
To: Josef Bacik, Chris Mason; +Cc: Linux BTRFS
With 3.4-rc4 under certain workloads, I see btrfs_block_rsv_check
return -ENOSPC.
Since btrfs_block_rsv_check can only return -ENOSPC or 0,
relocation.c:3816 checks for -EAGAIN, which is either redundant or
should be -ENOSPC, which I initially suspected.
Let me know which the behaviour should be and I'll get a patch tested and sent.
Thanks,
Daniel
--
Daniel J Blueman
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: block_rsv_check EAGAIN vs ENOSPC...
2012-04-24 15:50 block_rsv_check EAGAIN vs ENOSPC Daniel J Blueman
@ 2012-04-24 15:54 ` Josef Bacik
0 siblings, 0 replies; 2+ messages in thread
From: Josef Bacik @ 2012-04-24 15:54 UTC (permalink / raw)
To: Daniel J Blueman; +Cc: Josef Bacik, Chris Mason, Linux BTRFS
On Tue, Apr 24, 2012 at 11:50:24PM +0800, Daniel J Blueman wrote:
> With 3.4-rc4 under certain workloads, I see btrfs_block_rsv_check
> return -ENOSPC.
>
> Since btrfs_block_rsv_check can only return -ENOSPC or 0,
> relocation.c:3816 checks for -EAGAIN, which is either redundant or
> should be -ENOSPC, which I initially suspected.
>
> Let me know which the behaviour should be and I'll get a patch tested and sent.
>
Yup you are right, thanks,
Josef
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-24 15:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-24 15:50 block_rsv_check EAGAIN vs ENOSPC Daniel J Blueman
2012-04-24 15:54 ` Josef Bacik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).