From: Josef Bacik <josef@redhat.com>
To: Liu Bo <liubo2009@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: do not do balance in readonly mode
Date: Fri, 11 May 2012 10:50:19 -0400 [thread overview]
Message-ID: <20120511145018.GB3847@localhost.localdomain> (raw)
In-Reply-To: <1336731086-26077-1-git-send-email-liubo2009@cn.fujitsu.com>
On Fri, May 11, 2012 at 06:11:26PM +0800, Liu Bo wrote:
> In normal cases, we would not be allowed to do balance in RO mode.
> However, when we're using a seeding device and adding another device to sprout,
> things will change:
>
> $ mkfs.btrfs /dev/sdb7
> $ btrfstune -S 1 /dev/sdb7
> $ mount /dev/sdb7 /mnt/btrfs -o ro
> $ btrfs fi bal /mnt/btrfs -----------------------> fail.
> $ btrfs dev add /dev/sdb8 /mnt/btrfs
> $ btrfs fi bal /mnt/btrfs -----------------------> works!
>
> It should not be designed as an exception, and we'd better add another check for
> mnt flags.
>
Added to btrfs-next and added my Reviewed-by. Thanks,
Josef
prev parent reply other threads:[~2012-05-11 14:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 10:11 [PATCH] Btrfs: do not do balance in readonly mode Liu Bo
2012-05-11 14:50 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511145018.GB3847@localhost.localdomain \
--to=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).