From: Josef Bacik <josef@redhat.com>
To: Liu Bo <liubo2009@cn.fujitsu.com>
Cc: Josef Bacik <josef@redhat.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/4] Btrfs: track transaction aborted across the fs_info
Date: Fri, 1 Jun 2012 08:46:14 -0400 [thread overview]
Message-ID: <20120601124613.GB2652@localhost.localdomain> (raw)
In-Reply-To: <4FC8196D.8010407@cn.fujitsu.com>
On Fri, Jun 01, 2012 at 09:22:53AM +0800, Liu Bo wrote:
> On 06/01/2012 04:04 AM, Josef Bacik wrote:
>
> > If we abort a transaction during the commit phase we can have people who
> > start new transactions because we nave no way of signaling to them that
> > something went wrong. So add a trans_aborted flag to the fs_info so the
> > start transaction code can be notified that the last transaction was aborted
> > and it needs to return an error. Thanks,
> >
>
>
> We already have a (root->fs_info->fs_state & BTRFS_SUPER_FLAG_ERROR),
> why don't just use that?
>
Ah I missed all of that, will do, thanks,
Josef
next prev parent reply other threads:[~2012-06-01 12:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 20:04 [PATCH 1/4] Btrfs: wake up transaction waiters when aborting a transaction Josef Bacik
2012-05-31 20:04 ` [PATCH 2/4] Btrfs: track transaction aborted across the fs_info Josef Bacik
2012-06-01 1:22 ` Liu Bo
2012-06-01 12:46 ` Josef Bacik [this message]
2012-05-31 20:04 ` [PATCH 3/4] Btrfs: do not reset the eb ref count to 1 when aborting the transaction Josef Bacik
2012-05-31 20:04 ` [PATCH 4/4] Btrfs: unlock everything properly in the error case for nocow Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120601124613.GB2652@localhost.localdomain \
--to=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).