From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:63573 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754739Ab2FAMqx (ORCPT ); Fri, 1 Jun 2012 08:46:53 -0400 Date: Fri, 1 Jun 2012 08:46:49 -0400 From: Josef Bacik To: Miao Xie Cc: Josef Bacik , Linux Btrfs Subject: Re: [PATCH] Btrfs-progs: Update mtab if necessary when device was deleted in btrfs Message-ID: <20120601124648.GC2652@localhost.localdomain> References: <4FC747CF.2040703@cn.fujitsu.com> <20120531143148.GA2080@localhost.localdomain> <4FC81DDA.70004@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <4FC81DDA.70004@cn.fujitsu.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Fri, Jun 01, 2012 at 09:41:46AM +0800, Miao Xie wrote: > On Thu, 31 May 2012 10:31:48 -0400, Josef Bacik wrote: > > On Thu, May 31, 2012 at 06:28:31PM +0800, Miao Xie wrote: > >> Now if we remove the device that is specified when mounting, btrfs will update > >> the mount information in /proc, such as the information in /proc/mounts. So > >> in order to guarantee the consistency between /etc/mtab and the mount > >> information in /proc, we must update /etc/mtab. This patch does it. > >> > >> This patch need libmount and libmount-devel(version >= 2.19) packages to > >> compile. > >> > > > > Does this work well with say Fedora where /etc/mtab is just a symlink to > > /proc/mounts? Thanks, > > Yes, if /etc/mtab is not a regular file, we will skip the update. And I have > do some test for it and all of them passed. > > This patch can not work well on your machine? > It didn't but I think I screwed something up so ignore me. Thanks, Josef