From: Josef Bacik <josef@redhat.com>
To: Josef Bacik <josef@redhat.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/7] Btrfs: check the return code of btrfs_save_ino_cache
Date: Mon, 4 Jun 2012 14:07:16 -0400 [thread overview]
Message-ID: <20120604180703.GA1889@localhost.localdomain> (raw)
In-Reply-To: <1338558955-4944-4-git-send-email-josef@redhat.com>
On Fri, Jun 01, 2012 at 09:55:51AM -0400, Josef Bacik wrote:
> In doing my enospc work I would sometimes error out in btrfs_save_ino_cache
> which would abort the transaction but we'd still end up with a corrupted
> file system. This is because we don't actually check the return value and
> so if somethign goes wrong we just exit out and screw everything up. This
> fixes this particular part. Thanks,
Dropping this patch, it doesn't actually matter if the space cache gets written
out or not and it actually fails if the caching has not finished which can lead
to a transaction being aborted for no reason. Thanks,
Josef
next prev parent reply other threads:[~2012-06-04 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 13:55 Transaction abort fixes Josef Bacik
2012-06-01 13:55 ` [PATCH 1/7] Btrfs: pass locked_page into extent_clear_unlock_delalloc if theres an error Josef Bacik
2012-06-01 13:55 ` [PATCH 2/7] Btrfs: fix locking in btrfs_destroy_delayed_refs Josef Bacik
2012-06-01 13:55 ` [PATCH 3/7] Btrfs: check the return code of btrfs_save_ino_cache Josef Bacik
2012-06-04 18:07 ` Josef Bacik [this message]
2012-06-01 13:55 ` [PATCH 4/7] Btrfs: wake up transaction waiters when aborting a transaction Josef Bacik
2012-06-01 13:55 ` [PATCH 5/7] Btrfs: abort the transaction if the commit fails Josef Bacik
2012-06-01 13:55 ` [PATCH 6/7] Btrfs: fix btrfs_destroy_marked_extents Josef Bacik
2012-06-01 13:55 ` [PATCH 7/7] Btrfs: unlock everything properly in the error case for nocow Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120604180703.GA1889@localhost.localdomain \
--to=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).