From: Sami Liedes <sami.liedes@iki.fi>
To: Jan Schmidt <list.btrfs@jan-o-sch.net>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: btrfs GPF in read_extent_buffer() while scrubbing with kernel 3.4.2
Date: Tue, 3 Jul 2012 16:58:25 +0300 [thread overview]
Message-ID: <20120703135824.GA8908@sli.dy.fi> (raw)
In-Reply-To: <4FF2EF68.6090401@jan-o-sch.net>
[-- Attachment #1: Type: text/plain, Size: 1569 bytes --]
On Tue, Jul 03, 2012 at 03:11:04PM +0200, Jan Schmidt wrote:
> > The oops is transcribed from photos, so it may contain some errors. I
>
> You did *what*? :-) Uploading a photo would be fine, just in case that's easier
> for you the next time.
Nah, it's sometimes refreshing to do something that doesn't take too
much thinking for a while. Besides I fault myself for not having had
netconsole logging on that machine and needed to punish myself for
that omission ;)
> That's looking strange.
>
> I checked the readahead code again: It deliberately skips locking and uses
> btrfs_node_key with a counter variable. This means, we might end up reading a
> key that's no longer actually there. However, it only operates on nodes of
> trees, not leaves. Node entries have a fixed size, so no matter what changes in
> the node, you won't reach behind the end of that node with an index that was
> valid the moment before.
>
> As far as I see it, that algorithm is safe. It could miss some keys or do some
> extra work that's not strictly required, but it should never reach a GPF from
> btrfs_node_key.
>
> If no other ideas come up, I'd try memtesting that machine.
Ran a full pass of memtest86+ v4.20, with no errors found. Also the
machine works very well in all other respects under heavy load.
I think I might try setting up that netconsole to see if there are any
interesting console messages before the oops... As I said, I also was
able to reproduce this on 3.4.4, so ATM I assume I'm able to reproduce
this at will.
Sami
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-03 13:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 23:01 btrfs GPF in read_extent_buffer() while scrubbing with kernel 3.4.2 Sami Liedes
2012-07-02 23:08 ` Sami Liedes
2012-07-03 13:11 ` Jan Schmidt
2012-07-03 13:58 ` Sami Liedes [this message]
2012-07-03 14:35 ` Jan Schmidt
2012-07-03 22:47 ` Sami Liedes
2012-07-04 0:17 ` Sami Liedes
2012-07-04 11:26 ` Jan Schmidt
2012-07-04 16:03 ` Sami Liedes
2012-07-04 16:38 ` Jan Schmidt
2012-07-04 20:24 ` Sami Liedes
2012-07-05 13:41 ` Jan Schmidt
2012-07-05 23:47 ` Sami Liedes
2012-07-06 10:42 ` Jan Schmidt
2012-07-06 11:50 ` Chris Mason
2012-07-06 14:33 ` Sami Liedes
2012-07-06 14:40 ` Chris Mason
2012-07-06 15:02 ` Jan Schmidt
2012-07-06 15:19 ` Chris Mason
2012-07-06 15:09 ` Jan Schmidt
[not found] ` <20120706195923.GA10687@sli.dy.fi>
2012-07-06 21:41 ` Sami Liedes
2012-07-06 23:44 ` Sami Liedes
2012-07-09 9:05 ` *** GMX Spamverdacht *** " Arne Jansen
2012-07-10 4:16 ` Sami Liedes
2012-07-10 6:05 ` Arne Jansen
2012-07-10 6:57 ` *** GMX Spamverdacht *** " Arne Jansen
2012-07-16 8:20 ` Arne Jansen
2012-07-16 21:29 ` Sami Liedes
2012-07-28 12:08 ` Sami Liedes
2012-07-28 18:50 ` Sami Liedes
2012-07-03 13:14 ` Sami Liedes
2013-03-27 11:54 ` Stefan Behrens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120703135824.GA8908@sli.dy.fi \
--to=sami.liedes@iki.fi \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).