From: Chris Mason <chris.mason@fusionio.com>
To: Liu Bo <liubo2009@cn.fujitsu.com>
Cc: David Sterba <dave@jikos.cz>,
"Chris L. Mason" <clmason@fusionio.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Josef Bacik <JBacik@fusionio.com>
Subject: Re: [PATCH v3] Btrfs: improve multi-thread buffer read
Date: Fri, 20 Jul 2012 08:40:30 -0400 [thread overview]
Message-ID: <20120720124030.GI18878@shiny.int.fusionio.com> (raw)
In-Reply-To: <50077169.4070203@cn.fujitsu.com>
On Wed, Jul 18, 2012 at 08:31:05PM -0600, Liu Bo wrote:
> On 07/19/2012 10:05 AM, David Sterba wrote:
[ pagevec vs array ]
> Sorry, I see no difference between 16 pages array and pagevec(14 pages), and
> I have no idea why ext4 use 16 pages array(maybe historical reasons), but IMO
> it is proper and natural to use pagevec to manage pages.
>
> Anyway, either will be ok, but we'd better get Chris's confirmation.
>
> So Chris?
Yeah, the array does sound better, and I would go with 16. It's a nice
round number. Thanks Dave!
-chris
prev parent reply other threads:[~2012-07-20 12:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 18:05 [PATCH v3] Btrfs: improve multi-thread buffer read Liu Bo
2012-07-18 11:57 ` David Sterba
2012-07-19 1:11 ` Liu Bo
2012-07-19 2:05 ` David Sterba
2012-07-19 2:31 ` Liu Bo
2012-07-20 3:36 ` David Sterba
2012-07-20 3:51 ` Liu Bo
2012-07-20 12:40 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120720124030.GI18878@shiny.int.fusionio.com \
--to=chris.mason@fusionio.com \
--cc=JBacik@fusionio.com \
--cc=clmason@fusionio.com \
--cc=dave@jikos.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).