From: Josef Bacik <jbacik@fusionio.com>
To: Mitch Harder <mitch.harder@sabayonlinux.org>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 0/1] Btrfs: Explicitly include vmalloc.h in send.c
Date: Mon, 30 Jul 2012 09:46:07 -0400 [thread overview]
Message-ID: <20120730134607.GA15396@localhost.localdomain> (raw)
In-Reply-To: <1343514003-10942-1-git-send-email-mitch.harder@sabayonlinux.org>
On Sat, Jul 28, 2012 at 04:20:02PM -0600, Mitch Harder wrote:
> When compiling without SMP and generic x86_64, I encountered the
> following errors due to vmalloc.h not being implicitly included:
>
> CC fs/btrfs/send.o
> fs/btrfs/send.c: In function ‘fs_path_free’:
> fs/btrfs/send.c:185:4: error: implicit declaration of function ‘vfree’
> fs/btrfs/send.c: In function ‘fs_path_ensure_buf’:
> fs/btrfs/send.c:215:4: error: implicit declaration of function ‘vmalloc’
> fs/btrfs/send.c:215:12: warning: assignment makes pointer from integer without a cast
> fs/btrfs/send.c:225:12: warning: assignment makes pointer from integer without a cast
> fs/btrfs/send.c:233:13: warning: assignment makes pointer from integer without a cast
> fs/btrfs/send.c: In function ‘iterate_dir_item’:
> fs/btrfs/send.c:900:10: warning: assignment makes pointer from integer without a cast
> fs/btrfs/send.c:909:11: warning: assignment makes pointer from integer without a cast
> fs/btrfs/send.c: In function ‘btrfs_ioctl_send’:
> fs/btrfs/send.c:4462:17: warning: assignment makes pointer from integer without a cast
> fs/btrfs/send.c:4468:17: warning: assignment makes pointer from integer without a cast
> fs/btrfs/send.c:4474:2: error: implicit declaration of function ‘vzalloc’
> fs/btrfs/send.c:4474:20: warning: assignment makes pointer from integer without a cast
> fs/btrfs/send.c:4482:21: warning: assignment makes pointer from integer without a cast
> make[2]: *** [fs/btrfs/send.o] Error 1
> make[1]: *** [fs/btrfs] Error 2
>
> If it makes sense, please feel free to include this minor change in with
> other send/receive fixes.
>
> Mitch Harder (1):
> Btrfs: Explicitly include vmalloc.h in send.c
>
> fs/btrfs/send.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
Already fixed by the linux-next maintainer. Thanks,
Josef
prev parent reply other threads:[~2012-07-30 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 22:20 [PATCH 0/1] Btrfs: Explicitly include vmalloc.h in send.c Mitch Harder
2012-07-28 22:20 ` [PATCH 1/1] " Mitch Harder
2012-07-30 13:46 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730134607.GA15396@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=mitch.harder@sabayonlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).