From: Josef Bacik <jbacik@fusionio.com>
To: Miao Xie <miaox@cn.fujitsu.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [josef-btrfs:master 9/11] fs/btrfs/transaction.c:1118:6: warning: 'parent' may be used uninitialized in this function
Date: Thu, 2 Aug 2012 08:07:41 -0400 [thread overview]
Message-ID: <20120802120741.GE2263@localhost.localdomain> (raw)
In-Reply-To: <501A0221.4060204@cn.fujitsu.com>
On Wed, Aug 01, 2012 at 10:29:21PM -0600, Miao Xie wrote:
> On Thu, 2 Aug 2012 10:31:23 +0800, Fengguang Wu wrote:
> > There are new compile warnings show up in
> >
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git master
> > head: 8e1163044779e90662e96887cdd692c1594146ad
> > commit: dd817e81e81bbb83b63317b169d0e57a5d7ae0e1 [9/11] Btrfs: fix error path in create_pending_snapshot()
> > config: x86_64-randconfig-h031 (attached as .config)
> >
> > All error/warnings:
> >
> > fs/btrfs/transaction.c: In function 'create_pending_snapshot':
> > fs/btrfs/transaction.c:1118:6: warning: 'parent' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > fs/btrfs/transaction.c:1119:19: warning: 'rsv' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >
> > vim +1118 fs/btrfs/transaction.c
> > 1115 if (ret)
> > 1116 goto abort_trans;
> > 1117 fail:
> >> 1118 dput(parent);
> > 1119 trans->block_rsv = rsv;
> > 1120 no_free_objectid:
> > 1121 kfree(new_root_item);
>
> The patch I sent before is based on the v3.5.0, not Chris's latest for-linus branch, so...
>
> I will send new patches to fix it. Thanks for your report.
>
I've pulled these patches, Dave still has concerns about corruption. Thanks,
Josef
prev parent reply other threads:[~2012-08-02 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 2:31 [josef-btrfs:master 9/11] fs/btrfs/transaction.c:1118:6: warning: 'parent' may be used uninitialized in this function Fengguang Wu
2012-08-02 4:29 ` Miao Xie
2012-08-02 12:07 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120802120741.GE2263@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).