From: Chris Mason <chris.mason@fusionio.com>
To: David Sterba <dave@jikos.cz>
Cc: Alexander Block <ablock84@googlemail.com>,
Josef Bacik <JBacik@fusionio.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: remove mnt_want_write call in btrfs_mksubvol
Date: Wed, 8 Aug 2012 11:40:01 -0400 [thread overview]
Message-ID: <20120808154001.GA4185@shiny> (raw)
In-Reply-To: <20120808152059.GY17430@twin.jikos.cz>
On Wed, Aug 08, 2012 at 09:20:59AM -0600, David Sterba wrote:
> On Sat, Aug 04, 2012 at 01:39:25AM +0200, Alexander Block wrote:
> > On Fri, Aug 3, 2012 at 11:13 PM, Josef Bacik <jbacik@fusionio.com> wrote:
> > > I'm confused, this isn't here in btrfs-next, so is this a problem still?
> >
> > It's in linus current master. Lio Bo moved the call out of
> > btrfs_mksubvol into the caller. Later a commit from Jan Kara tried to
> > move the call inside mksubvol below i_mutex. If I understand the logs
> > correctly, It was then merged incorrectly.
>
> How should we resolve this? The patch has to be pulled via a separate
> branch, based on top of linus/master, as cmason/for-linus does not have
> the clashing freezer patches. And I do want to see the fix in master
> rather soon as it makes testing tedious.
Right, I'll fix this up in a separate send to Linus. I thought I had
this fixed in my original merge, but either way I'll send a pull to fix
it.
-chris
prev parent reply other threads:[~2012-08-08 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 23:16 [PATCH] Btrfs: remove mnt_want_write call in btrfs_mksubvol Alexander Block
2012-08-03 21:13 ` Josef Bacik
2012-08-03 23:39 ` Alexander Block
2012-08-08 15:20 ` David Sterba
2012-08-08 15:40 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120808154001.GA4185@shiny \
--to=chris.mason@fusionio.com \
--cc=JBacik@fusionio.com \
--cc=ablock84@googlemail.com \
--cc=dave@jikos.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).