From: David Sterba <dave@jikos.cz>
To: bo.li.liu@oracle.com
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix ordered extent leak when failing to start a transaction
Date: Fri, 24 Aug 2012 16:19:37 +0200 [thread overview]
Message-ID: <20120824141937.GA17430@twin.jikos.cz> (raw)
In-Reply-To: <1345605205-18685-1-git-send-email-bo.li.liu@oracle.com>
On Wed, Aug 22, 2012 at 11:13:25AM +0800, bo.li.liu@oracle.com wrote:
> We cannot just return error before freeing ordered extent and releasing reserved
> space when we fail to start a transacion.
>
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
> ---
> fs/btrfs/inode.c | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 7131fac..f6c43ff 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -1883,8 +1883,11 @@ static int btrfs_finish_ordered_io(struct btrfs_ordered_extent *ordered_extent)
> trans = btrfs_join_transaction_nolock(root);
> else
> trans = btrfs_join_transaction(root);
> - if (IS_ERR(trans))
> - return PTR_ERR(trans);
> + if (IS_ERR(trans)) {
> + ret = PTR_ERR(trans);
> + trans = NULL;
> + goto out;
> + }
The same code is used a few lines below (after locking the range) when
transaction fails, so I agree that this should be done here as well. Ack.
david
prev parent reply other threads:[~2012-08-24 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 3:13 [PATCH] Btrfs: fix ordered extent leak when failing to start a transaction bo.li.liu
2012-08-24 14:19 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120824141937.GA17430@twin.jikos.cz \
--to=dave@jikos.cz \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).